<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14541">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_04_11.c: do not abuse LOG_TRANS() in gsm411_alloc_mt_trans()<br><br>This change is similar to I6b68a0f0b32eb126e0f7e914a314130254d28467.<br>If we 100% sure that trans == NULL, it makes more sense to use<br>generic LOGP(DLSMS, LOGL_*, ...) call, so the logs can reflect<br>more information than such dummy prefix:<br><br>  trans(NULL NULL callref-0x0 tid-0) ...<br><br>Change-Id: I3c1e633aee5dd7cd0d367404a3def9cffe0b3baa<br>---<br>M src/libmsc/gsm_04_11.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c</span><br><span>index 3a3ec8c..367cc6f 100644</span><br><span>--- a/src/libmsc/gsm_04_11.c</span><br><span>+++ b/src/libmsc/gsm_04_11.c</span><br><span>@@ -1097,13 +1097,13 @@</span><br><span>                                               struct vlr_subscr *vsub)</span><br><span> {</span><br><span>         struct msc_a *msc_a;</span><br><span style="color: hsl(0, 100%, 40%);">-    struct gsm_trans *trans = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+       struct gsm_trans *trans;</span><br><span>     int tid;</span><br><span> </span><br><span>         /* Generate a new transaction ID */</span><br><span>  tid = trans_assign_trans_id(net, vsub, TRANS_SMS);</span><br><span>   if (tid == -1) {</span><br><span style="color: hsl(0, 100%, 40%);">-                LOG_TRANS(trans, LOGL_ERROR, "No available transaction IDs\n");</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGP(DLSMS, LOGL_ERROR, "No available transaction IDs\n");</span><br><span>                 return NULL;</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14541">change 14541</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14541"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3c1e633aee5dd7cd0d367404a3def9cffe0b3baa </div>
<div style="display:none"> Gerrit-Change-Number: 14541 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>