<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14540">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_04_11_gsup.c: fix broken reference counting for vsub<br><br>This change is similar to I5540556b1c75f6873883e46b78656f31fc1ef186.<br>In gsm411_gsup_rx() we do call vlr_subscr_find_by_imsi(), which<br>increases subscriber's reference count by one using the function<br>name as the token. However, we never release this token, so the<br>reference count grows on every received GSUP FORWARD-SM message.<br><br>Change-Id: Ic729beb5f94cbbfbb251bc9ab66a5e7b799286c0<br>---<br>M src/libmsc/gsm_04_11_gsup.c<br>1 file changed, 11 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/40/14540/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c</span><br><span>index 331092a..2abfc92 100644</span><br><span>--- a/src/libmsc/gsm_04_11_gsup.c</span><br><span>+++ b/src/libmsc/gsm_04_11_gsup.c</span><br><span>@@ -287,8 +287,10 @@</span><br><span> int gsm411_gsup_rx(struct gsup_client_mux *gcm, void *data, const struct osmo_gsup_message *gsup_msg)</span><br><span> {</span><br><span>    struct gsm_network *net = (struct gsm_network *) data;</span><br><span style="color: hsl(0, 100%, 40%);">-  struct vlr_subscr *vsub = vlr_subscr_find_by_imsi(net->vlr, gsup_msg->imsi, __func__);</span><br><span style="color: hsl(120, 100%, 40%);">+  struct vlr_subscr *vsub;</span><br><span style="color: hsl(120, 100%, 40%);">+      int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   vsub = vlr_subscr_find_by_imsi(net->vlr, gsup_msg->imsi, __func__);</span><br><span>    if (!vsub) {</span><br><span>                 LOGP(DLSMS, LOGL_ERROR, "Rx %s for unknown subscriber, rejecting\n",</span><br><span>                    osmo_gsup_message_type_name(gsup_msg->message_type));</span><br><span>@@ -303,16 +305,21 @@</span><br><span>        case OSMO_GSUP_MSGT_READY_FOR_SM_ERROR:</span><br><span>      case OSMO_GSUP_MSGT_READY_FOR_SM_RESULT:</span><br><span>             DEBUGP(DMSC, "Routed to GSM 04.11 MO handler\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             return gsm411_gsup_mo_handler(net, vsub, gsup_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = gsm411_gsup_mo_handler(net, vsub, gsup_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span> </span><br><span>   /* GSM 04.11 code implementing MT SMS */</span><br><span>     case OSMO_GSUP_MSGT_MT_FORWARD_SM_REQUEST:</span><br><span>           DEBUGP(DMSC, "Routed to GSM 04.11 MT handler\n");</span><br><span style="color: hsl(0, 100%, 40%);">-             return gsm411_gsup_mt_handler(net, vsub, gsup_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+           rc = gsm411_gsup_mt_handler(net, vsub, gsup_msg);</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span> </span><br><span>   default:</span><br><span>             LOGP(DMM, LOGL_ERROR, "No handler found for %s, dropping message...\n",</span><br><span>                    osmo_gsup_message_type_name(gsup_msg->message_type));</span><br><span style="color: hsl(0, 100%, 40%);">-                return -GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL;</span><br><span style="color: hsl(120, 100%, 40%);">+              rc = -GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL;</span><br><span>       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   vlr_subscr_put(vsub, __func__);</span><br><span style="color: hsl(120, 100%, 40%);">+       return rc;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14540">change 14540</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14540"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic729beb5f94cbbfbb251bc9ab66a5e7b799286c0 </div>
<div style="display:none"> Gerrit-Change-Number: 14540 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>