<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14514">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests/msc_vlr: fix: do not pass RAT type to expect_bssap_clear()<br><br>The function name implies OSMO_RAT_GERAN_A, and it has nothing<br>to do with other OSMO_RAT_* types. Found using clang:<br><br>  warning: too many arguments in call to 'expect_bssap_clear'<br>           expect_bssap_clear(OSMO_RAT_GERAN_A);<br>                              ^^^^^^^^^^^^^^^^<br><br>Change-Id: Id3a3af33fcc5da4ca4c48a2f589a69f3568d2586<br>---<br>M tests/msc_vlr/msc_vlr_test_gsm_authen.c<br>M tests/msc_vlr/msc_vlr_test_gsm_ciph.c<br>M tests/msc_vlr/msc_vlr_test_no_authen.c<br>M tests/msc_vlr/msc_vlr_test_reject_concurrency.c<br>4 files changed, 11 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/14514/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/msc_vlr/msc_vlr_test_gsm_authen.c b/tests/msc_vlr/msc_vlr_test_gsm_authen.c</span><br><span>index 8776e03..ee5af1e 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_gsm_authen.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_gsm_authen.c</span><br><span>@@ -113,7 +113,7 @@</span><br><span>     VERBOSE_ASSERT(cm_service_result_sent, == RES_ACCEPT, "%d");</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -327,7 +327,7 @@</span><br><span>        VERBOSE_ASSERT(cm_service_result_sent, == RES_ACCEPT, "%d");</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -1017,7 +1017,7 @@</span><br><span>      VERBOSE_ASSERT(cm_service_result_sent, == RES_ACCEPT, "%d");</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c</span><br><span>index c76cba4..155afbe 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_gsm_ciph.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_gsm_ciph.c</span><br><span>@@ -128,7 +128,7 @@</span><br><span>       VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d");</span><br><span> </span><br><span>     /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -363,7 +363,7 @@</span><br><span>        VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d");</span><br><span> </span><br><span>     /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -967,7 +967,7 @@</span><br><span>        VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d");</span><br><span> </span><br><span>     /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -1158,7 +1158,7 @@</span><br><span>      VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d");</span><br><span> </span><br><span>     /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -1375,7 +1375,7 @@</span><br><span>      VERBOSE_ASSERT(cm_service_result_sent, == RES_NONE, "%d");</span><br><span> </span><br><span>     /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_no_authen.c b/tests/msc_vlr/msc_vlr_test_no_authen.c</span><br><span>index ae77252..9d506d6 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_no_authen.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_no_authen.c</span><br><span>@@ -69,7 +69,7 @@</span><br><span>     EXPECT_ACCEPTED(true);</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>@@ -227,7 +227,7 @@</span><br><span>        EXPECT_ACCEPTED(true);</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_reject_concurrency.c b/tests/msc_vlr/msc_vlr_test_reject_concurrency.c</span><br><span>index fe53469..648313f 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_reject_concurrency.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_reject_concurrency.c</span><br><span>@@ -308,7 +308,7 @@</span><br><span>       BTW("The original CM Service Request can conclude");</span><br><span> </span><br><span>   /* Release connection */</span><br><span style="color: hsl(0, 100%, 40%);">-        expect_bssap_clear(OSMO_RAT_GERAN_A);</span><br><span style="color: hsl(120, 100%, 40%);">+ expect_bssap_clear();</span><br><span>        conn_conclude_cm_service_req(g_msub, MSC_A_USE_CM_SERVICE_SMS);</span><br><span> </span><br><span>  btw("all requests serviced, conn has been released");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14514">change 14514</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14514"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id3a3af33fcc5da4ca4c48a2f589a69f3568d2586 </div>
<div style="display:none"> Gerrit-Change-Number: 14514 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>