<p>fixeria <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14466">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_09_11.c: drop meaningless check for concurrent paging<br><br>This check was copy-pasted from the CC handling code during the<br>initial development of "SS/USSD over GSUP" feature. It probably<br>makes sense for MT calls, but definitely not for SS/USSD.<br><br>Change-Id: I2899a23ee49fd7917443943629603700a5025cf4<br>---<br>M src/libmsc/gsm_09_11.c<br>1 file changed, 1 insertion(+), 15 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index bcf8dec..f85c3f6 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -314,7 +314,7 @@</span><br><span>        struct vlr_subscr *vsub, const struct osmo_gsup_message *gsup_msg)</span><br><span> {</span><br><span>      struct msc_a *msc_a;</span><br><span style="color: hsl(0, 100%, 40%);">-    struct gsm_trans *trans, *transt;</span><br><span style="color: hsl(120, 100%, 40%);">+     struct gsm_trans *trans;</span><br><span>     int tid;</span><br><span> </span><br><span>         if (gsup_msg->session_state != OSMO_GSUP_SESSION_STATE_BEGIN) {</span><br><span>@@ -363,20 +363,6 @@</span><br><span> </span><br><span>        LOG_TRANS(trans, LOGL_DEBUG, "Triggering Paging Request\n");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      /* Find transaction with this subscriber already paging */</span><br><span style="color: hsl(0, 100%, 40%);">-      llist_for_each_entry(transt, &net->trans_list, entry) {</span><br><span style="color: hsl(0, 100%, 40%);">-          /* Transaction of our conn? */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (transt == trans || transt->vsub != vsub)</span><br><span style="color: hsl(0, 100%, 40%);">-                 continue;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-               LOG_TRANS(trans, LOGL_ERROR, "Paging already started, "</span><br><span style="color: hsl(0, 100%, 40%);">-                       "rejecting message...\n");</span><br><span style="color: hsl(0, 100%, 40%);">-            trans_free(trans);</span><br><span style="color: hsl(0, 100%, 40%);">-              /* FIXME: WTF IS THIS!? This is completely insane. Presence of a trans doesn't indicate Paging, and even</span><br><span style="color: hsl(0, 100%, 40%);">-             * if, why drop the current request??? */</span><br><span style="color: hsl(0, 100%, 40%);">-               return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Trigger Paging Request */</span><br><span>         trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_SIGNALLING_HIGH_PRIO,</span><br><span>                                                  ss_paging_cb, trans, "GSM 09.11 SS/USSD");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14466">change 14466</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14466"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2899a23ee49fd7917443943629603700a5025cf4 </div>
<div style="display:none"> Gerrit-Change-Number: 14466 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>