<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14501">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_09_11.c: do not abuse LOG_TRANS() in gsm0911_rcv_nc_ss()<br><br>If we 100% sure that trans == NULL, it makes more sense to use<br>generic LOGP(DSS, LOGL_*, ...) call, so the logs can reflect<br>more information than such dummy prefix:<br><br>  trans(NULL NULL callref-0x0 tid-0) ...<br><br>Change-Id: I6b68a0f0b32eb126e0f7e914a314130254d28467<br>---<br>M src/libmsc/gsm_09_11.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index c7b2155..df0a9b4 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -135,8 +135,9 @@</span><br><span>                 * a supplementary service.</span><br><span>           */</span><br><span>          if (msg_type != GSM0480_MTYPE_REGISTER) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       LOG_TRANS(trans, LOGL_ERROR, "Rx wrong SS/USSD message type for new transaction: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                                 gsm48_pdisc_msgtype_name(GSM48_PDISC_NC_SS, msg_type));</span><br><span style="color: hsl(120, 100%, 40%);">+                     LOGP(DSS, LOGL_ERROR, "Rx %s message for non-existing transaction (tid-%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                gsm48_pdisc_msgtype_name(GSM48_PDISC_NC_SS, msg_type),</span><br><span style="color: hsl(120, 100%, 40%);">+                                gsm48_hdr_trans_id(gh));</span><br><span>                   gsm48_tx_simple(msc_a,</span><br><span>                               GSM48_PDISC_NC_SS | (tid << 4),</span><br><span>                                GSM0480_MTYPE_RELEASE_COMPLETE);</span><br><span>@@ -145,7 +146,7 @@</span><br><span> </span><br><span>           trans = trans_alloc(net, vsub, TRANS_USSD, tid, new_callref++);</span><br><span>              if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   LOG_TRANS(trans, LOGL_ERROR, " -> No memory for trans\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGP(DSS, LOGL_ERROR, " -> No memory for trans\n");</span><br><span>                     gsm48_tx_simple(msc_a,</span><br><span>                               GSM48_PDISC_NC_SS | (tid << 4),</span><br><span>                                GSM0480_MTYPE_RELEASE_COMPLETE);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14501">change 14501</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14501"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6b68a0f0b32eb126e0f7e914a314130254d28467 </div>
<div style="display:none"> Gerrit-Change-Number: 14501 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>