<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/14480">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">decompress_crbb: replace int8_t with uint8_t as length<br><br>There should not be a negative length.<br><br>Change-Id: I7099bff92eba3bf4db8601a2575c721e2579ce8e<br>---<br>M src/egprs_rlc_compression.cpp<br>M src/egprs_rlc_compression.h<br>M tests/bitcomp/BitcompTest.cpp<br>3 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/80/14480/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/egprs_rlc_compression.cpp b/src/egprs_rlc_compression.cpp</span><br><span>index 7eeb7d2..927c6cd 100644</span><br><span>--- a/src/egprs_rlc_compression.cpp</span><br><span>+++ b/src/egprs_rlc_compression.cpp</span><br><span>@@ -486,14 +486,14 @@</span><br><span> }</span><br><span> </span><br><span> /* Decompress received block bitmap</span><br><span style="color: hsl(0, 100%, 40%);">- * \param compress_bmap_len[in] Compressed bitmap length</span><br><span style="color: hsl(120, 100%, 40%);">+ * \param compress_bmap_len[in] Compressed bitmap length in bits</span><br><span>  * \param start[in] Starting Color Code, true if bitmap starts with a run</span><br><span>  *              length of ones, false if zeros; see 9.1.10, 3GPP 44.060.</span><br><span>  * \param orig_crbb_buf[in] Received block crbb bitmap</span><br><span>  * \param dest[out] Uncompressed bitvector</span><br><span>  */</span><br><span> int egprs_compress::decompress_crbb(</span><br><span style="color: hsl(0, 100%, 40%);">-             int8_t compress_bmap_len,</span><br><span style="color: hsl(120, 100%, 40%);">+             uint8_t compress_bmap_len,</span><br><span>           bool start,</span><br><span>          const uint8_t *orig_crbb_buf,</span><br><span>                bitvec *dest)</span><br><span>diff --git a/src/egprs_rlc_compression.h b/src/egprs_rlc_compression.h</span><br><span>index 4d2501b..dd1b9b9 100644</span><br><span>--- a/src/egprs_rlc_compression.h</span><br><span>+++ b/src/egprs_rlc_compression.h</span><br><span>@@ -11,7 +11,7 @@</span><br><span> class egprs_compress</span><br><span> {</span><br><span> public:</span><br><span style="color: hsl(0, 100%, 40%);">-      static int decompress_crbb(int8_t compress_bmap_len,</span><br><span style="color: hsl(120, 100%, 40%);">+  static int decompress_crbb(uint8_t compress_bmap_len,</span><br><span>                bool start, const uint8_t *orig_buf,</span><br><span>                 bitvec *dest);</span><br><span>       egprs_compress();</span><br><span>diff --git a/tests/bitcomp/BitcompTest.cpp b/tests/bitcomp/BitcompTest.cpp</span><br><span>index 98bb2cc..29a8c15 100644</span><br><span>--- a/tests/bitcomp/BitcompTest.cpp</span><br><span>+++ b/tests/bitcomp/BitcompTest.cpp</span><br><span>@@ -24,7 +24,7 @@</span><br><span> void *tall_pcu_ctx;</span><br><span> </span><br><span> struct test_data {</span><br><span style="color: hsl(0, 100%, 40%);">- int8_t crbb_len;</span><br><span style="color: hsl(120, 100%, 40%);">+      uint8_t crbb_len;</span><br><span>    uint8_t cc;</span><br><span>  uint8_t crbb_data[MAX_CRBB_LEN]; /* compressed data */</span><br><span>       uint8_t ucmp_data[MAX_URBB_LEN]; /* uncompressed data */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/14480">change 14480</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/14480"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7099bff92eba3bf4db8601a2575c721e2579ce8e </div>
<div style="display:none"> Gerrit-Change-Number: 14480 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>