<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14472">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm<br><br>Since [1] has been merged to libosmocore, it was discovered that<br>the 'msc_a' FSM has a dummy 'allstate_action' handler assigned,<br>but 'allstate_event_mask' is 0x00 at the same time.<br><br>It basically doesn't make any sense, and moreover does cause<br>warnings and build failures.<br><br>[1] https://git.osmocom.org/libosmocore/commit/?id=b3f94eb39e19366c3458643ee329a73155d46ff8<br>[1] https://gerrit.osmocom.org/#/c/libosmocore/+/14361/<br><br>Change-Id: Ieb81b7a07ced1c40ba70d2adb0df68160ee62118<br>---<br>M src/libmsc/msc_a.c<br>1 file changed, 0 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/72/14472/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_a.c b/src/libmsc/msc_a.c</span><br><span>index b311df3..bd69eed 100644</span><br><span>--- a/src/libmsc/msc_a.c</span><br><span>+++ b/src/libmsc/msc_a.c</span><br><span>@@ -809,16 +809,6 @@</span><br><span>               osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, fi);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void msc_a_fsm_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">-        //struct msc_a *a = msc_a_fi_priv(fi);</span><br><span style="color: hsl(0, 100%, 40%);">-  switch (event) {</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-        default:</span><br><span style="color: hsl(0, 100%, 40%);">-                return;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> void msc_a_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause)</span><br><span> {</span><br><span>  struct msc_a *msc_a = msc_a_fi_priv(fi);</span><br><span>@@ -991,9 +981,6 @@</span><br><span>       .num_states = ARRAY_SIZE(msc_a_fsm_states),</span><br><span>  .log_subsys = DMSC,</span><br><span>  .event_names = msc_a_fsm_event_names,</span><br><span style="color: hsl(0, 100%, 40%);">-   .allstate_action = msc_a_fsm_allstate_action,</span><br><span style="color: hsl(0, 100%, 40%);">-   .allstate_event_mask = 0</span><br><span style="color: hsl(0, 100%, 40%);">-                ,</span><br><span>    .timer_cb = msc_a_fsm_timer_cb,</span><br><span>      .cleanup = msc_a_fsm_cleanup,</span><br><span> };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14472">change 14472</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14472"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieb81b7a07ced1c40ba70d2adb0df68160ee62118 </div>
<div style="display:none"> Gerrit-Change-Number: 14472 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>