<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14461">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_09_11.c: fix: return trans from establish_nc_ss_trans()<br><br>It is expected that establish_nc_ss_trans() returns an allocated<br>transaction in successful case, or NULL in case of error. The<br>function assumes two scenarios:<br><br>  - the subscriber already has an active RAN connection,<br>  - RAN connection needs to be established (Paging).<br><br>In the first case, a pointer to the transaction is returned as<br>expected, but in case of Paging, NULL has always been returned,<br>even if there were no errors. Let's fix this.<br><br>Change-Id: I9dcee64dd0b435ef29630c223132b81724701f93<br>---<br>M src/libmsc/gsm_09_11.c<br>M tests/msc_vlr/msc_vlr_test_ss.err<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/61/14461/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index 3de933c..39b9711 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -409,7 +409,7 @@</span><br><span>   msgb_tlv_put(trans->ss.msg, GSM0480_IE_FACILITY,</span><br><span>          gsup_msg->ss_info_len, gsup_msg->ss_info);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  return trans;</span><br><span> }</span><br><span> </span><br><span> /* NC SS specific transaction release.</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_ss.err b/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>index 976b263..1199cf1 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_ss.err</span><br><span>@@ -375,7 +375,7 @@</span><br><span>   paging request (SIGNALLING_HIGH_PRIO) to IMSI-901700000004620:MSISDN-46071 on GERAN-A</span><br><span>   strcmp(paging_expecting_imsi, vsub->imsi) == 0</span><br><span> DREF VLR subscr IMSI-901700000004620:MSISDN-46071 + Paging: now used by 5 (attached,_test_ss_ussd_no,gsm0911_gsup_rx,NCSS,Paging)</span><br><span style="color: hsl(0, 100%, 40%);">-<-- GSUP rx OSMO_GSUP_MSGT_PROC_SS_REQUEST: vlr_gsupc_read_cb() returns -22</span><br><span style="color: hsl(120, 100%, 40%);">+<-- GSUP rx OSMO_GSUP_MSGT_PROC_SS_REQUEST: vlr_gsupc_read_cb() returns 0</span><br><span>   llist_count(&vsub->cs.requests) == 1</span><br><span> DREF VLR subscr IMSI-901700000004620:MSISDN-46071 - _test_ss_ussd_no: now used by 4 (attached,gsm0911_gsup_rx,NCSS,Paging)</span><br><span>   paging_sent == 1</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14461">change 14461</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14461"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9dcee64dd0b435ef29630c223132b81724701f93 </div>
<div style="display:none"> Gerrit-Change-Number: 14461 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>