<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14473">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "fsm.c: Print error message for FSM with allstate_action but no events"<br><br>This reverts commit b3f94eb39e19366c3458643ee329a73155d46ff8, that<br>unfortunately breaks some projects which call osmo_fsm_register()<br>on DSO load (i.e. using __attribute__((constructor))) before the<br>logging is initialized.<br><br>Change-Id: Idc6fcce7e946c23d48589b920e309d60aa7b6645<br>---<br>M src/fsm.c<br>1 file changed, 0 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/73/14473/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/fsm.c b/src/fsm.c</span><br><span>index 04c583b..337786d 100644</span><br><span>--- a/src/fsm.c</span><br><span>+++ b/src/fsm.c</span><br><span>@@ -256,17 +256,6 @@</span><br><span>            return -EEXIST;</span><br><span>      if (fsm->event_names == NULL)</span><br><span>             LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has no event names! Please fix!\n", fsm->name);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if (fsm->allstate_action && !fsm->allstate_event_mask) {</span><br><span style="color: hsl(0, 100%, 40%);">-          LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_action but no allstate_event_mask\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                       fsm->name);</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       if (!fsm->allstate_action && fsm->allstate_event_mask) {</span><br><span style="color: hsl(0, 100%, 40%);">-          LOGP(DLGLOBAL, LOGL_ERROR, "FSM '%s' has allstate_event_mask but no allstate_action\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                       fsm->name);</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    llist_add_tail(&fsm->list, &osmo_g_fsms);</span><br><span>         INIT_LLIST_HEAD(&fsm->instances);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14473">change 14473</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14473"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idc6fcce7e946c23d48589b920e309d60aa7b6645 </div>
<div style="display:none"> Gerrit-Change-Number: 14473 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>