<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14453">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsup_client_mux_tx_error_reply(): fix: do not omit session IEs<br><br>For SS/USSD, it's important to have both session state and ID IEs.<br>Found using the new TC_mt_ussd_for_unknown_subscr test case.<br><br>Change-Id: I57317a7b8036d1ffd36e2021efc146db4633da84<br>Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe<br>Related: OS#2931<br>---<br>M src/libmsc/gsup_client_mux.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c</span><br><span>index 292c2a9..8c80a6b 100644</span><br><span>--- a/src/libmsc/gsup_client_mux.c</span><br><span>+++ b/src/libmsc/gsup_client_mux.c</span><br><span>@@ -157,6 +157,12 @@</span><br><span> </span><br><span>         OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  /* For SS/USSD, it's important to keep both session state and ID IEs */</span><br><span style="color: hsl(120, 100%, 40%);">+   if (gsup_orig->session_state != OSMO_GSUP_SESSION_STATE_NONE) {</span><br><span style="color: hsl(120, 100%, 40%);">+            gsup_reply.session_state = OSMO_GSUP_SESSION_STATE_END;</span><br><span style="color: hsl(120, 100%, 40%);">+               gsup_reply.session_id = gsup_orig->session_id;</span><br><span style="color: hsl(120, 100%, 40%);">+     }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  if (osmo_gsup_client_enc_send(gcm->gsup_client, &gsup_reply))</span><br><span>                 LOGP(DLGSUP, LOGL_ERROR, "Failed to send Error reply (imsi=%s)\n",</span><br><span>                      osmo_quote_str(gsup_orig->imsi, -1));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14453">change 14453</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14453"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I57317a7b8036d1ffd36e2021efc146db4633da84 </div>
<div style="display:none"> Gerrit-Change-Number: 14453 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>