<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14458">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message where needed<br><br>OsmoMSC should notify the remote SS/USSD entity if:<br><br>  - received GSUP message has unexpected session state;<br>  - received GSUP message has unknown session ID;<br>  - received GSUP message missing mandatory IE(s);<br>  - NCSS transaction establishment failed;<br>  - NCSS message delivery failed.<br><br>Change-Id: Ief9f8a197b0860072b671edfc55180f619860d9d<br>Related: (TTCN-3) Ie267ee174c5061cd3fc102a2824abe03d73f3aac<br>Related: OS#2931<br>---<br>M src/libmsc/gsm_09_11.c<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/58/14458/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c</span><br><span>index 3de933c..82a045d 100644</span><br><span>--- a/src/libmsc/gsm_09_11.c</span><br><span>+++ b/src/libmsc/gsm_09_11.c</span><br><span>@@ -475,7 +475,7 @@</span><br><span>                /* Attempt to establish a new transaction */</span><br><span>                 trans = establish_nc_ss_trans(net, vsub, gsup_msg);</span><br><span>          if (!trans) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   /* FIXME: send ERROR back to the HLR */</span><br><span style="color: hsl(120, 100%, 40%);">+                       gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_NET_FAIL);</span><br><span>                   return -EINVAL;</span><br><span>              }</span><br><span> </span><br><span>@@ -520,7 +520,7 @@</span><br><span>  default:</span><br><span>             LOG_TRANS(trans, LOGL_ERROR, "Unexpected session state %d\n",</span><br><span>                      gsup_msg->session_state);</span><br><span style="color: hsl(0, 100%, 40%);">-            /* FIXME: send ERROR back to the HLR */</span><br><span style="color: hsl(120, 100%, 40%);">+               gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_MSGT_INCOMP_P_STATE);</span><br><span>                msgb_free(ss_msg);</span><br><span>           return -EINVAL;</span><br><span>      }</span><br><span>@@ -530,7 +530,7 @@</span><br><span>              if (!gsup_msg->ss_info || gsup_msg->ss_info_len < 2) {</span><br><span>                      LOG_TRANS(trans, LOGL_ERROR, "Missing mandatory Facility IE "</span><br><span>                              "for mapped 0x%02x message\n", gh->msg_type);</span><br><span style="color: hsl(0, 100%, 40%);">-                      /* FIXME: send ERROR back to the HLR */</span><br><span style="color: hsl(120, 100%, 40%);">+                       gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_INV_MAND_INFO);</span><br><span>                      msgb_free(ss_msg);</span><br><span>                   return -EINVAL;</span><br><span>              }</span><br><span>@@ -553,6 +553,7 @@</span><br><span>      msc_a = trans->msc_a;</span><br><span>     if (!msc_a) {</span><br><span>                LOG_TRANS(trans, LOGL_ERROR, "Cannot send SS message, no local MSC-A role defined for subscriber\n");</span><br><span style="color: hsl(120, 100%, 40%);">+               gsup_client_mux_tx_error_reply(gcm, gsup_msg, GMM_CAUSE_NET_FAIL);</span><br><span>           msgb_free(ss_msg);</span><br><span>           return -EINVAL;</span><br><span>      }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14458">change 14458</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14458"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ief9f8a197b0860072b671edfc55180f619860d9d </div>
<div style="display:none"> Gerrit-Change-Number: 14458 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>