<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14447">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">command.c: Improve return check condition in cmd_execut_command_real()<br><br>Check against MAX argc is changed to == since it cannot be incremented<br>twice without passing the check.<br><br>Change-Id: Ia330e475989fda863bedcc3cbf94deaf8dd83037<br>---<br>M src/vty/command.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/47/14447/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/command.c b/src/vty/command.c</span><br><span>index 4189c7c..b26e991 100644</span><br><span>--- a/src/vty/command.c</span><br><span>+++ b/src/vty/command.c</span><br><span>@@ -2313,7 +2313,7 @@</span><br><span>                               argv[argc++] = vector_slot(vline, i);</span><br><span>                }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           if (argc >= CMD_ARGC_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+          if (argc == CMD_ARGC_MAX)</span><br><span>                    return CMD_ERR_EXEED_ARGC_MAX;</span><br><span>       }</span><br><span> </span><br><span>@@ -2458,7 +2458,7 @@</span><br><span>                                argv[argc++] = vector_slot(vline, i);</span><br><span>                }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           if (argc >= CMD_ARGC_MAX)</span><br><span style="color: hsl(120, 100%, 40%);">+          if (argc == CMD_ARGC_MAX)</span><br><span>                    return CMD_ERR_EXEED_ARGC_MAX;</span><br><span>       }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14447">change 14447</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14447"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia330e475989fda863bedcc3cbf94deaf8dd83037 </div>
<div style="display:none"> Gerrit-Change-Number: 14447 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>