<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14431">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty: tests: Verify incomplete optional parameters are passed to vty funcs<br><br>The test shows that in the case were "single0 on" is executed, VTY<br>function should return complete "single0 one" but it doesn't.<br><br>Related: OS#4045<br>Change-Id: Ib5b9dc07e2b280dc95011b3926afb1d490cadd81<br>---<br>M tests/vty/vty_transcript_test.c<br>M tests/vty/vty_transcript_test.vty<br>2 files changed, 18 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/vty/vty_transcript_test.c b/tests/vty/vty_transcript_test.c</span><br><span>index 7ffe713..6651097 100644</span><br><span>--- a/tests/vty/vty_transcript_test.c</span><br><span>+++ b/tests/vty/vty_transcript_test.c</span><br><span>@@ -154,6 +154,14 @@</span><br><span>    .num_cat = ARRAY_SIZE(default_categories),</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(single0, single0_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+      "single0 [one]",</span><br><span style="color: hsl(120, 100%, 40%);">+      "single0 test command\n" "1\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+     vty_out(vty, "ok argc=%d%s%s%s", argc, argc ? " " : "", argc ? argv[0] : "", VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+    return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> DEFUN(multi0, multi0_cmd,</span><br><span>       "multi0 (one|two|three)",</span><br><span>       "multi0 test command\n" "1\n2\n3\n")</span><br><span>@@ -180,6 +188,7 @@</span><br><span> </span><br><span> static void init_vty_cmds()</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+    install_element_ve(&single0_cmd);</span><br><span>        install_element_ve(&multi0_cmd);</span><br><span>         install_element_ve(&multi1_cmd);</span><br><span>         install_element_ve(&multi2_cmd);</span><br><span>diff --git a/tests/vty/vty_transcript_test.vty b/tests/vty/vty_transcript_test.vty</span><br><span>index 5ed3c1d..1557744 100644</span><br><span>--- a/tests/vty/vty_transcript_test.vty</span><br><span>+++ b/tests/vty/vty_transcript_test.vty</span><br><span>@@ -75,3 +75,12 @@</span><br><span> </span><br><span> vty_transcript_test> multi2 t</span><br><span> % Ambiguous command.</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+vty_transcript_test> single0 one</span><br><span style="color: hsl(120, 100%, 40%);">+ok argc=1 one</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+vty_transcript_test> single0 on</span><br><span style="color: hsl(120, 100%, 40%);">+ok argc=1 on</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+vty_transcript_test> single0</span><br><span style="color: hsl(120, 100%, 40%);">+ok argc=0</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14431">change 14431</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14431"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib5b9dc07e2b280dc95011b3926afb1d490cadd81 </div>
<div style="display:none"> Gerrit-Change-Number: 14431 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>