<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14452">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsup_client_mux_tx_error_reply(): fix: do not override IMSI<br><br>I am not a big fan of using such syntax sugar for initializing<br>structures, and this is one of the reasons: it's much easier<br>to shoot yourself in the foot.<br><br>IMSI was copied to the new GSUP message, but then overridden.<br>Found using the new TC_mt_ussd_for_unknown_subscr test case.<br><br>Change-Id: If81c3fa56951185339f33a523ab6364594101be1<br>Related: (TTCN-3) Id35cd3ec15d1bab15260312d7bbb41e2d10349fe<br>Related: OS#2931<br>---<br>M src/libmsc/gsup_client_mux.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/gsup_client_mux.c b/src/libmsc/gsup_client_mux.c</span><br><span>index 7ec1712..292c2a9 100644</span><br><span>--- a/src/libmsc/gsup_client_mux.c</span><br><span>+++ b/src/libmsc/gsup_client_mux.c</span><br><span>@@ -150,13 +150,13 @@</span><br><span>    if (!OSMO_GSUP_IS_MSGT_REQUEST(gsup_orig->message_type))</span><br><span>          return;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     gsup_reply = (struct osmo_gsup_message){</span><br><span>             .cause = cause,</span><br><span>              .message_type = OSMO_GSUP_TO_MSGT_ERROR(gsup_orig->message_type),</span><br><span>         };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_STRLCPY_ARRAY(gsup_reply.imsi, gsup_orig->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   if (osmo_gsup_client_enc_send(gcm->gsup_client, &gsup_reply))</span><br><span>                 LOGP(DLGSUP, LOGL_ERROR, "Failed to send Error reply (imsi=%s)\n",</span><br><span>                      osmo_quote_str(gsup_orig->imsi, -1));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14452">change 14452</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14452"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If81c3fa56951185339f33a523ab6364594101be1 </div>
<div style="display:none"> Gerrit-Change-Number: 14452 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>