<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14450">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MSC_Tests.ttcn: introduce TC_mt_ussd_for_unknown_subscr<br><br>The idea of this test case is to check that OsmoMSC properly<br>rejects SS/USSD requests for unknown subscribers.<br><br>Running this test case against the current OsmoMSC helped<br>to discover several problems:<br><br> - OsmoMSC doesn't print anything in such cases;<br> - IMSI in the response error message is empty;<br> - both session state and ID IEs are omited;<br><br>which are going to be fixed soon.<br><br>Change-Id: Id35cd3ec15d1bab15260312d7bbb41e2d10349fe<br>Related: OS#2931<br>---<br>M msc/MSC_Tests.ttcn<br>1 file changed, 51 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 2c898fc..c57328f 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -3453,6 +3453,55 @@</span><br><span> f_vty_config(MSCVTY, "msc", "ncss guard-timeout 0");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* MT (network-originated) USSD for unknown subscriber */</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_tc_mt_ussd_for_unknown_subscr(charstring id, BSC_ConnHdlrPars pars)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on BSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var hexstring imsi := '000000000000000'H; /* Some unknown IMSI */</span><br><span style="color: hsl(120, 100%, 40%);">+ var OCT4 sid := '20000222'O;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 2.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_handler(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ran_register_imsi(imsi, 'FFFFFFFF'O);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_create_gsup_expect(hex2str(imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) GSUP_PDU gsup_req := ts_GSUP_PROC_SS_REQ(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sid := sid,</span><br><span style="color: hsl(120, 100%, 40%);">+ state := OSMO_GSUP_SESSION_STATE_BEGIN,</span><br><span style="color: hsl(120, 100%, 40%);">+ ss := f_rnd_octstring(23)</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Error with cause GMM_CAUSE_IMSI_UNKNOWN */</span><br><span style="color: hsl(120, 100%, 40%);">+ var template GSUP_PDU gsup_rsp := tr_GSUP_PROC_SS_ERR(</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi := imsi,</span><br><span style="color: hsl(120, 100%, 40%);">+ sid := sid,</span><br><span style="color: hsl(120, 100%, 40%);">+ state := OSMO_GSUP_SESSION_STATE_END,</span><br><span style="color: hsl(120, 100%, 40%);">+ cause := 2 /* FIXME: introduce an enumerated type! */</span><br><span style="color: hsl(120, 100%, 40%);">+ );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initiate a MT USSD notification */</span><br><span style="color: hsl(120, 100%, 40%);">+ GSUP.send(gsup_req);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect GSUP PROC_SS_ERROR message */</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GSUP.receive(gsup_rsp) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for GSUP PROC_SS_ERROR message");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* We don't expect anything else */</span><br><span style="color: hsl(120, 100%, 40%);">+ [] as_unexp_gsup_or_bssap_msg();</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_mt_ussd_for_unknown_subscr() runs on MTC_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSC_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_tc_mt_ussd_for_unknown_subscr), 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> /* A5/1 only permitted on network side; attempt an invalid CIPHER MODE COMPLETE with A5/3 which MSC should reject. */</span><br><span> private function f_tc_cipher_complete_with_invalid_cipher(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr {</span><br><span>@@ -5301,6 +5350,8 @@</span><br><span> execute( TC_lu_and_mo_ussd_mo_release() );</span><br><span> execute( TC_lu_and_ss_session_timeout() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_mt_ussd_for_unknown_subscr() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> execute( TC_cipher_complete_with_invalid_cipher() );</span><br><span> execute( TC_cipher_complete_1_without_cipher() );</span><br><span> execute( TC_cipher_complete_3_without_cipher() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14450">change 14450</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14450"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id35cd3ec15d1bab15260312d7bbb41e2d10349fe </div>
<div style="display:none"> Gerrit-Change-Number: 14450 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>