<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/L1CTL_PortType.ttcn: clarify and unify timeout messages<br><br>It's way more cleaner when you see:<br><br> Timeout waiting for L1CTL_RACH_CONF<br><br>instead of:<br><br> Timeout in RACH.<br><br>Change-Id: I25e8230c2e4b29b2583bf8954d0dedaa18e5d6ae<br>---<br>M library/L1CTL_PortType.ttcn<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/L1CTL_PortType.ttcn b/library/L1CTL_PortType.ttcn</span><br><span>index 7af680c..2423715 100644</span><br><span>--- a/library/L1CTL_PortType.ttcn</span><br><span>+++ b/library/L1CTL_PortType.ttcn</span><br><span>@@ -59,7 +59,7 @@</span><br><span> }</span><br><span> [] pt.receive { repeat; };</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout in FBSB") </span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L1CTL_FBSB_CONF");</span><br><span> mtc.stop;</span><br><span> };</span><br><span> }</span><br><span>@@ -74,7 +74,7 @@</span><br><span> [] pt.receive(tr_L1CTL_CCCH_MODE_CONF) { }</span><br><span> [] pt.receive { repeat; }</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout in CCH_MODE");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L1CTL_CCCH_MODE_CONF");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> }</span><br><span>@@ -93,7 +93,7 @@</span><br><span> [] pt.receive(tr_L1CTL_RACH_CONF) -> value rc { fn := rc.dl_info.frame_nr };</span><br><span> [] pt.receive { repeat; };</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout in RACH");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L1CTL_RACH_CONF");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> }</span><br><span>@@ -114,7 +114,7 @@</span><br><span> [] pt.receive(tr_L1CTL_RACH_CONF) -> value rc { fn := rc.dl_info.frame_nr };</span><br><span> [] pt.receive { repeat; };</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout in extended RACH");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for (extended) L1CTL_RACH_CONF");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> }</span><br><span>@@ -168,7 +168,7 @@</span><br><span> };</span><br><span> [] pt.receive { repeat };</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout waiting for IMM ASS");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for TBF IMM ASS");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> }</span><br><span>@@ -184,7 +184,7 @@</span><br><span> [] pt.receive(tr_L1CTL_TBF_CFG_CONF(is_uplink)) {}</span><br><span> [] pt.receive { repeat };</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout waiting for TBF-CFG.conf");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L1CTL_TBF_CFG_CONF");</span><br><span> mtc.stop;</span><br><span> };</span><br><span> }</span><br><span>@@ -213,7 +213,7 @@</span><br><span> [] pt.receive(tr_L1CTL_MsgType(L1CTL_RESET_CONF)) { }</span><br><span> [] pt.receive { repeat; }</span><br><span> [] T.timeout {</span><br><span style="color: hsl(0, 100%, 40%);">- setverdict(fail, "Timeout waiting for RESET.conf");</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for L1CTL_RESET_CONF");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420">change 14420</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I25e8230c2e4b29b2583bf8954d0dedaa18e5d6ae </div>
<div style="display:none"> Gerrit-Change-Number: 14420 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>