<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/14433">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14433/1/jenkins-common.sh">File jenkins-common.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14433/1/jenkins-common.sh@43">Patch Set #1, Line 43:</a> <code style="font-family:monospace,monospace">  NO_DOCKER_IMAGE_BUILD=1 docker_images_require debian-stretch-build</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would change this to the following, so it would build the image if it does not exist, but not try to update the image if does exist:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> if ! docker_image_exists "debian-stretch-build"; then<br>      docker_images_require "debian-stretch-build"<br> fi</pre><p style="white-space: pre-wrap; word-wrap: break-word;">With your version, it would exit with an error here if it did not exists.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/14433">change 14433</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/14433"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib008ee72f40aeefb307c0ba74a57b70daae9d07b </div>
<div style="display:none"> Gerrit-Change-Number: 14433 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Jun 2019 09:16:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>