<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14408">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
osmith: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Fix trailing whitespace<br><br>Change-Id: I97c6cc290d6cc23611ac38e7e370b5b0b88cca1d<br>---<br>M bsc/BSC_Tests.ttcn<br>M bsc/MSC_ConnectionHandler.ttcn<br>M library/IPA_Emulation.ttcnpp<br>M library/Osmocom_CTRL_Functions.ttcn<br>4 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index 518f9e1..c3275e1 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -1263,7 +1263,7 @@</span><br><span> </span><br><span> f_bssap_tx_ud(ts_BSSMAP_Paging(imsi, cid_list, tmsi, bssmap_chneed));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* FIXME: Disabled due to bugs in both GSM_RR_Types and MobileL3_CommonIE_Types IMSI encoder </span><br><span style="color: hsl(120, 100%, 40%);">+/* FIXME: Disabled due to bugs in both GSM_RR_Types and MobileL3_CommonIE_Types IMSI encoder</span><br><span> if (isvalue(tmsi)) {</span><br><span> mi := valueof(t_Osmo_MI_TMSI(oct2int(valueof(tmsi))));</span><br><span> } else {</span><br><span>@@ -3171,7 +3171,7 @@</span><br><span> var octetstring ho_command_str;</span><br><span> </span><br><span> BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap;</span><br><span style="color: hsl(0, 100%, 40%);">- </span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> ho_command_str := rx_bssap.pdu.bssmap.handoverRequestAck.layer3Information.layer3info;</span><br><span> log("Received L3 Info in HO Request Ack: ", ho_command_str);</span><br><span> var PDU_ML3_NW_MS ho_command := dec_PDU_ML3_NW_MS(ho_command_str);</span><br><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index c7f6495..c709794 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -1091,7 +1091,7 @@</span><br><span> }</span><br><span> }</span><br><span> [st.rr_ho_cmpl_seen] as_Media_ipacc();</span><br><span style="color: hsl(0, 100%, 40%);">- [st.rr_ho_cmpl_seen] as_Media_mgw(true); </span><br><span style="color: hsl(120, 100%, 40%);">+ [st.rr_ho_cmpl_seen] as_Media_mgw(true);</span><br><span> [st.rr_ho_cmpl_seen] RSL.receive(tr_RSL_DEACT_SACCH(st.old_chan_nr)) {</span><br><span> repeat;</span><br><span> }</span><br><span>diff --git a/library/IPA_Emulation.ttcnpp b/library/IPA_Emulation.ttcnpp</span><br><span>index 3180621..3ec6922 100644</span><br><span>--- a/library/IPA_Emulation.ttcnpp</span><br><span>+++ b/library/IPA_Emulation.ttcnpp</span><br><span>@@ -2,7 +2,7 @@</span><br><span> </span><br><span> /* This module implements the IPA multiplex protocol on top of TCP, using the IPL4asp</span><br><span> * test-port as provider. It implements both client and server roles, as well was the CCM</span><br><span style="color: hsl(0, 100%, 40%);">- * handshake for establishing the identity of the client to the server. </span><br><span style="color: hsl(120, 100%, 40%);">+ * handshake for establishing the identity of the client to the server.</span><br><span> *</span><br><span> * It already knows certain well-known sub-protocols such as A-bis RSL, MGCP and SCCP and</span><br><span> * GSUP. IT hence transcodes messages so the user can work with abstract data types rather</span><br><span>@@ -258,7 +258,7 @@</span><br><span> function f_bind(charstring local_host, IPL4asp_Types.PortNumber local_port,</span><br><span> IPA_CCM_Parameters ccm_pars := c_IPA_default_ccm_pars) runs on IPA_Emulation_CT {</span><br><span> var IPL4asp_Types.Result res;</span><br><span style="color: hsl(0, 100%, 40%);">- res := IPA_CodecPort_CtrlFunct.f_IPL4_listen(IPA_PORT, </span><br><span style="color: hsl(120, 100%, 40%);">+ res := IPA_CodecPort_CtrlFunct.f_IPL4_listen(IPA_PORT,</span><br><span> local_host, local_port, { tcp:={} });</span><br><span> if (not ispresent(res.connId)) {</span><br><span> setverdict(fail, "Could not listen IPA socket ", local_host, ":", local_port, ", check your configuration");</span><br><span>diff --git a/library/Osmocom_CTRL_Functions.ttcn b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>index 4356ba9..94dcb8a 100644</span><br><span>--- a/library/Osmocom_CTRL_Functions.ttcn</span><br><span>+++ b/library/Osmocom_CTRL_Functions.ttcn</span><br><span>@@ -6,7 +6,7 @@</span><br><span> * implements blocking functions, instead of asynchronous functions. The</span><br><span> * rationale for this is simple: One normally wants to inquire a value or set</span><br><span> * a value and not continue the main program until that operation is complete.</span><br><span style="color: hsl(0, 100%, 40%);">- * </span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span> * CTRL is a machine-type protocol on how external programs can interact with</span><br><span> * an Osmocom program in a structured way. It is intended for programmatic</span><br><span> * access (by other software), as opposed to the VTY interface intended for</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14408">change 14408</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14408"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I97c6cc290d6cc23611ac38e7e370b5b0b88cca1d </div>
<div style="display:none"> Gerrit-Change-Number: 14408 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>