<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14338">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Update T200 timer default values<br><br>The default values of 1s were *very* long, particularly for fast<br>channels such as FACCH.  Let's use much more aggressive values<br>that are more in-line with various recommendations that cold be<br>found online, such as<br>https://pcstelconext.wordpress.com/2011/05/02/2g-timer-explanations/<br>https://www.erlang.com/forum/erlang/thread.htx?thread=2844<br>https://www.erlang.com/forum/erlang/thread.htx?thread=7180<br>https://de.slideshare.net/BisiAdebambo/138078380-gsmtimers-59637131<br><br>Change-Id: Ic1268ae2d769b12da6cdd4ac8375e4bc033a9e3e<br>---<br>M src/common/oml.c<br>1 file changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index ad58cb9..7d24509 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -476,16 +476,16 @@</span><br><span>  return oml_mo_send_msg(mo, nmsg, NM_MT_SW_ACTIVATED_REP);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* The defaults below correspond to the libosmocore default of 1s for</span><br><span style="color: hsl(0, 100%, 40%);">- * DCCH and 2s for ACCH. The BSC should override this via OML anyway. */</span><br><span style="color: hsl(120, 100%, 40%);">+/* The defaults below correspond to various sources/recommendations that could be found online.</span><br><span style="color: hsl(120, 100%, 40%);">+ * The BSC should override this via OML anyway. */</span><br><span> const unsigned int oml_default_t200_ms[7] = {</span><br><span style="color: hsl(0, 100%, 40%);">-   [T200_SDCCH]            = 1000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_FACCH_F]          = 1000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_FACCH_H]          = 1000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_TCH_SAPI0]  = 2000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_SDCCH]      = 2000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SDCCH_SAPI3]      = 1000,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_TCH_SAPI3]  = 2000,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_SDCCH]            =  220,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_SDCCH_SAPI3]      =  450,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_SACCH_SDCCH]      =  900,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_FACCH_F]          =  250,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_FACCH_H]          =  250,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_SACCH_TCH_SAPI0]  = 1500,</span><br><span style="color: hsl(120, 100%, 40%);">+       [T200_SACCH_TCH_SAPI3]  = 1500,</span><br><span> };</span><br><span> </span><br><span> static void dl_set_t200(struct gsm_bts *bts, struct lapdm_datalink *dl, unsigned int t200_msec)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14338">change 14338</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14338"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic1268ae2d769b12da6cdd4ac8375e4bc033a9e3e </div>
<div style="display:none"> Gerrit-Change-Number: 14338 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>