<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14429">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14429/2/src/logging.c">File src/logging.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14429/2/src/logging.c@370">Patch Set #2, Line 370:</a> <code style="font-family:monospace,monospace">snprintf</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Hmm, I think I see a possible optimization:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /* man ctime: we need at least 26 bytes */<br>  if (rem < 26)<br>    goto err;</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /* Get human-readable representation of time */<br>  if (!ctime_r(&tm, buf + offset))<br>    goto err;</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  /* Get rid of useless '\n' */<br>  ret = strlen(buf + offset) - 1;<br>  if (ret <= 0)<br>    goto err;</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  OSMO_SNPRINTF_RET(ret, rem, offset, len);</pre><p style="white-space: pre-wrap; word-wrap: break-word;">So we can avoid calling snprintf() and overriding '\n' manually.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14429">change 14429</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14429"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I19ebf29a2f1fc855bb7d56766b338c7c3432dfd1 </div>
<div style="display:none"> Gerrit-Change-Number: 14429 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 12 Jun 2019 18:04:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>