<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14426">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">protocol/gsm_04_08.h: do not check if unsigned is positive<br><br>Change-Id: I6b486b52a3733d5fd5e8ba18acbc9374e2e8bd7e<br>---<br>M include/osmocom/gsm/protocol/gsm_04_08.h<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/14426/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>index 16910c3..2be6ed3 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>@@ -719,7 +719,7 @@</span><br><span>  */</span><br><span> static inline void gsm48_barr_acc(struct gsm48_rach_control *rach_control, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-    OSMO_ASSERT(acc >= 0 && acc <= 15);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(acc <= 15);</span><br><span>   if (acc >= 8)</span><br><span>             rach_control->t2 |= (1 << (acc - 8));</span><br><span>       else</span><br><span>@@ -733,7 +733,7 @@</span><br><span>  */</span><br><span> static inline void gsm48_allow_acc(struct gsm48_rach_control *rach_control, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(acc >= 0 && acc <= 15);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(acc <= 15);</span><br><span>   if (acc >= 8)</span><br><span>             rach_control->t2 &= ~(1 << (acc - 8));</span><br><span>  else</span><br><span>@@ -748,7 +748,7 @@</span><br><span>  */</span><br><span> static inline bool gsm48_acc_is_barred(struct gsm48_rach_control *rach_control, unsigned int acc)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     OSMO_ASSERT(acc >= 0 && acc <= 15);</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_ASSERT(acc <= 15);</span><br><span>   if (acc >= 8)</span><br><span>             return (rach_control->t2 & (1 << (acc - 8))) != 0;</span><br><span>      return (rach_control->t3 & (1 << (acc))) != 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14426">change 14426</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14426"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6b486b52a3733d5fd5e8ba18acbc9374e2e8bd7e </div>
<div style="display:none"> Gerrit-Change-Number: 14426 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>