<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14368">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: Fix stream_stats checks with overrun/underrun<br><br>It was initially thought that underruns/overrun fields were<br>increasing-over-time values.<br>However, after reading LimeSuite code, it seems overrun and<br>underrun fields are actually reset upon every call to<br>LMS_GetStreamStatus().<br><br>Related: osmo-trx.git 928177125654c1e596ec3450a68882c031ebb929<br>Related: https://github.com/myriadrf/LimeSuite/issues/265<br>Change-Id: I677232a7b12ee83d26aa34d92f76a91d4b5a63a6<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/68/14368/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index 7d3ce81..0253d4c 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -583,23 +583,23 @@</span><br><span>           return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (status.underrun > m_ctr[chan].rx_underruns) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (status.underrun) {</span><br><span>               changed = true;</span><br><span>              *underrun = true;</span><br><span>            LOGCHAN(chan, DDEV, ERROR) << "recv Underrun! ("</span><br><span>                                        << m_ctr[chan].rx_underruns << " -> "</span><br><span>                                       << status.underrun << ")";</span><br><span>  }</span><br><span style="color: hsl(0, 100%, 40%);">-       m_ctr[chan].rx_underruns = status.underrun;</span><br><span style="color: hsl(120, 100%, 40%);">+   m_ctr[chan].rx_underruns += status.underrun;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (status.overrun > m_ctr[chan].rx_overruns) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (status.overrun) {</span><br><span>                changed = true;</span><br><span>              *overrun = true;</span><br><span>             LOGCHAN(chan, DDEV, ERROR) << "recv Overrun! ("</span><br><span>                                         << m_ctr[chan].rx_overruns << " -> "</span><br><span>                                        << status.overrun << ")";</span><br><span>   }</span><br><span style="color: hsl(0, 100%, 40%);">-       m_ctr[chan].rx_overruns = status.overrun;</span><br><span style="color: hsl(120, 100%, 40%);">+     m_ctr[chan].rx_overruns += status.overrun;</span><br><span> </span><br><span>       if (status.droppedPackets) {</span><br><span>                 changed = true;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14368">change 14368</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14368"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I677232a7b12ee83d26aa34d92f76a91d4b5a63a6 </div>
<div style="display:none"> Gerrit-Change-Number: 14368 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>