<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14287">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Fix undefined behaviour shifting beyond sign bit<br><br>Fixes following ASan complaint during VTY "show running-config":<br>osmo-ggsn/ggsn/ggsn_vty.c:657:37: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'<br><br>Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869<br>---<br>M ggsn/ggsn_vty.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c</span><br><span>index 3f012d2..9101361 100644</span><br><span>--- a/ggsn/ggsn_vty.c</span><br><span>+++ b/ggsn/ggsn_vty.c</span><br><span>@@ -654,9 +654,9 @@</span><br><span>             vty_out(vty, "  ipdown-script %s%s", apn->tun.cfg.ipdown_script, VTY_NEWLINE);</span><br><span> </span><br><span>      for (i = 0; i < 32; i++) {</span><br><span style="color: hsl(0, 100%, 40%);">-           if (!(apn->cfg.apn_type_mask & (1 << i)))</span><br><span style="color: hsl(120, 100%, 40%);">+                if (!(apn->cfg.apn_type_mask & (UINT32_C(1) << i)))</span><br><span>                     continue;</span><br><span style="color: hsl(0, 100%, 40%);">-               vty_out(vty, "  type-support %s%s", get_value_string(pdp_type_names, (1 << i)),</span><br><span style="color: hsl(120, 100%, 40%);">+               vty_out(vty, "  type-support %s%s", get_value_string(pdp_type_names, (UINT32_C(1) << i)),</span><br><span>                    VTY_NEWLINE);</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14287">change 14287</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14287"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2b8d163dbc108b0fb5a1e820dc23181835d12869 </div>
<div style="display:none"> Gerrit-Change-Number: 14287 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>