<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14284">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp_create_pdp_ind: simplify code by reordering and compacting parsing<br><br>Move all parsing with same conditions under same blocks to make code<br>easier to follow and make it more compact.<br><br>Change-Id: I52d5a3543ce6cf764bd84303b5a0d8b0643d998d<br>---<br>M gtp/gtp.c<br>1 file changed, 92 insertions(+), 120 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index b05eed6..6e834cc 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -1435,6 +1435,61 @@</span><br><span> pdp->apn_req = linked_pdp->apn_req;</span><br><span> pdp->teic_gn = linked_pdp->teic_gn;</span><br><span> pdp->secondary = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* IMSI (conditional): If the MS is emergency attached</span><br><span style="color: hsl(120, 100%, 40%);">+ and the MS is UICCless, the IMSI cannot be included</span><br><span style="color: hsl(120, 100%, 40%);">+ in the message and therefore IMSI shall not be</span><br><span style="color: hsl(120, 100%, 40%);">+ included in the message. */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettv0</span><br><span style="color: hsl(120, 100%, 40%);">+ (ie, GTPIE_IMSI, 0, &pdp->imsi, sizeof(pdp->imsi))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing IMSI not supported\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TEID (mandatory) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettv4(ie, GTPIE_TEI_DI, 0, &pdp->teid_gn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TEIC (conditional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!linked_pdp) { /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettv4(ie, GTPIE_TEI_C, 0, &pdp->teic_gn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer,</span><br><span style="color: hsl(120, 100%, 40%);">+ pack, len,</span><br><span style="color: hsl(120, 100%, 40%);">+ "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* NSAPI (mandatory) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettv1(ie, GTPIE_NSAPI, 0, &pdp->nsapi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* QoS (mandatory) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettlv(ie, GTPIE_QOS_PROFILE, 0, &pdp->qos_req.l,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->qos_req.v, sizeof(pdp->qos_req.v))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* TFT (conditional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettlv(ie, GTPIE_TFT, 0, &pdp->tft.l,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->tft.v, sizeof(pdp->tft.v))) {</span><br><span> }</span><br><span> }</span><br><span> /* if (version == 1) */</span><br><span>@@ -1447,40 +1502,6 @@</span><br><span> return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span> GTPCAUSE_MAN_IE_MISSING);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if ((version == 1) && (!linked_pdp)) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(0, 100%, 40%);">- /* IMSI (conditional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettv0</span><br><span style="color: hsl(0, 100%, 40%);">- (ie, GTPIE_IMSI, 0, &pdp->imsi, sizeof(pdp->imsi))) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Recovery (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!gtpie_gettv1(ie, GTPIE_RECOVERY, 0, &recovery)) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* we use recovery futher down after announcing new pdp ctx to user */</span><br><span style="color: hsl(0, 100%, 40%);">- recovery_recvd = true;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Selection mode (conditional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!linked_pdp) { /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettv0(ie, GTPIE_SELECTION_MODE, 0,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->selmode, sizeof(pdp->selmode))) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (version == 0) {</span><br><span> if (gtpie_gettv2(ie, GTPIE_FL_DI, 0, &pdp->flru)) {</span><br><span> gsn->missing++;</span><br><span> GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span>@@ -1488,7 +1509,6 @@</span><br><span> return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span> GTPCAUSE_MAN_IE_MISSING);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> if (gtpie_gettv2(ie, GTPIE_FL_C, 0, &pdp->flrc)) {</span><br><span> gsn->missing++;</span><br><span> GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span>@@ -1498,70 +1518,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (version == 1) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* TEID (mandatory) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettv4(ie, GTPIE_TEI_DI, 0, &pdp->teid_gn)) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* TEIC (conditional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!linked_pdp) { /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettv4(ie, GTPIE_TEI_C, 0, &pdp->teic_gn)) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer,</span><br><span style="color: hsl(0, 100%, 40%);">- pack, len,</span><br><span style="color: hsl(0, 100%, 40%);">- "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* NSAPI (mandatory) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettv1(ie, GTPIE_NSAPI, 0, &pdp->nsapi)) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Charging Characteriatics (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">- /* Trace reference (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">- /* Trace type (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">- /* Charging Characteriatics (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!linked_pdp) { /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(0, 100%, 40%);">- /* End User Address (conditional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->eua.v, sizeof(pdp->eua.v))) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* APN */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettlv(ie, GTPIE_APN, 0, &pdp->apn_req.l,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->apn_req.v, sizeof(pdp->apn_req.v))) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Extract protocol configuration options (optional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (!gtpie_gettlv(ie, GTPIE_PCO, 0, &pdp->pco_req.l,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->pco_req.v, sizeof(pdp->pco_req.v))) {</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* SGSN address for signalling (mandatory) */</span><br><span> if (gtpie_gettlv(ie, GTPIE_GSN_ADDR, 0, &pdp->gsnrc.l,</span><br><span> &pdp->gsnrc.v, sizeof(pdp->gsnrc.v))) {</span><br><span>@@ -1581,8 +1537,44 @@</span><br><span> return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span> GTPCAUSE_MAN_IE_MISSING);</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Recovery (optional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!gtpie_gettv1(ie, GTPIE_RECOVERY, 0, &recovery)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* we use recovery futher down after announcing new pdp ctx to user */</span><br><span style="color: hsl(120, 100%, 40%);">+ recovery_recvd = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> if (!linked_pdp) { /* Not Secondary PDP Context Activation Procedure */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Selection mode (conditional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettv0(ie, GTPIE_SELECTION_MODE, 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->selmode, sizeof(pdp->selmode))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* End User Address (conditional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->eua.v, sizeof(pdp->eua.v))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* APN */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (gtpie_gettlv(ie, GTPIE_APN, 0, &pdp->apn_req.l,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->apn_req.v, sizeof(pdp->apn_req.v))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ gsn->missing++;</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(120, 100%, 40%);">+ len, "Missing mandatory information field\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Extract protocol configuration options (optional) */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!gtpie_gettlv(ie, GTPIE_PCO, 0, &pdp->pco_req.l,</span><br><span style="color: hsl(120, 100%, 40%);">+ &pdp->pco_req.v, sizeof(pdp->pco_req.v))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> /* MSISDN (conditional) */</span><br><span> if (gtpie_gettlv(ie, GTPIE_MSISDN, 0, &pdp->msisdn.l,</span><br><span> &pdp->msisdn.v, sizeof(pdp->msisdn.v))) {</span><br><span>@@ -1594,26 +1586,6 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (version == 1) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* QoS (mandatory) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettlv(ie, GTPIE_QOS_PROFILE, 0, &pdp->qos_req.l,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->qos_req.v, sizeof(pdp->qos_req.v))) {</span><br><span style="color: hsl(0, 100%, 40%);">- gsn->missing++;</span><br><span style="color: hsl(0, 100%, 40%);">- GTP_LOGPKG(LOGL_ERROR, peer, pack,</span><br><span style="color: hsl(0, 100%, 40%);">- len, "Missing mandatory information field\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return gtp_create_pdp_resp(gsn, version, pdp,</span><br><span style="color: hsl(0, 100%, 40%);">- GTPCAUSE_MAN_IE_MISSING);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* TFT (conditional) */</span><br><span style="color: hsl(0, 100%, 40%);">- if (gtpie_gettlv(ie, GTPIE_TFT, 0, &pdp->tft.l,</span><br><span style="color: hsl(0, 100%, 40%);">- &pdp->tft.v, sizeof(pdp->tft.v))) {</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Trigger ID */</span><br><span style="color: hsl(0, 100%, 40%);">- /* OMC identity */</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* Initialize our own IP addresses */</span><br><span> in_addr2gsna(&pdp->gsnlc, &gsn->gsnc);</span><br><span> in_addr2gsna(&pdp->gsnlu, &gsn->gsnu);</span><br><span>@@ -1688,7 +1660,7 @@</span><br><span> if (pdp)</span><br><span> pdp->gsn = gsn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Callback function to validata login */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Callback function to validate login */</span><br><span> if (gsn->cb_create_context_ind != 0)</span><br><span> rc = gsn->cb_create_context_ind(pdp);</span><br><span> else {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14284">change 14284</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14284"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I52d5a3543ce6cf764bd84303b5a0d8b0643d998d </div>
<div style="display:none"> Gerrit-Change-Number: 14284 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: merged </div>