<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14286">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: gtp: Document free pdp ctx in non-teardown scenario<br><br>Change-Id: Ia47ac792111fe1e9aa68222b32b5da823642206b<br>---<br>M gtp/gtp.c<br>1 file changed, 25 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 57c19a2..5dde6b5 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -2409,6 +2409,18 @@</span><br><span> if (teardown) { /* Remove all contexts */</span><br><span> gtp_freepdp_teardown(gsn, linked_pdp);</span><br><span> } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If we end up here (no teardown) it means we still</span><br><span style="color: hsl(120, 100%, 40%);">+ have at least another pdp context active for this</span><br><span style="color: hsl(120, 100%, 40%);">+ PDN connection (since last DeleteReq should come</span><br><span style="color: hsl(120, 100%, 40%);">+ with teardown enabled). If the ctx to delete is a</span><br><span style="color: hsl(120, 100%, 40%);">+ secondary ctx, simply free it. If it's the primary</span><br><span style="color: hsl(120, 100%, 40%);">+ ctx, mark it as nodata but don't free it since we</span><br><span style="color: hsl(120, 100%, 40%);">+ need it to hold data linked together and we'll</span><br><span style="color: hsl(120, 100%, 40%);">+ require it later to tear down the entire tree. Still,</span><br><span style="color: hsl(120, 100%, 40%);">+ we announce its deletion through cb_delete_context</span><br><span style="color: hsl(120, 100%, 40%);">+ because we don't want user to release its related</span><br><span style="color: hsl(120, 100%, 40%);">+ data and not use it anymore.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> if (gsn->cb_delete_context)</span><br><span> gsn->cb_delete_context(pdp);</span><br><span> if (pdp == linked_pdp) {</span><br><span>@@ -2485,7 +2497,19 @@</span><br><span> if (cause == GTPCAUSE_ACC_REQ) {</span><br><span> if ((teardown) || (version == 0)) { /* Remove all contexts */</span><br><span> gtp_freepdp_teardown(gsn, linked_pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- } else { /* Remove only current context */</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If we end up here (no teardown) it means we still</span><br><span style="color: hsl(120, 100%, 40%);">+ have at least another pdp context active for this</span><br><span style="color: hsl(120, 100%, 40%);">+ PDN connection (since last DeleteReq should come</span><br><span style="color: hsl(120, 100%, 40%);">+ with teardown enabled). If the ctx to delete is a</span><br><span style="color: hsl(120, 100%, 40%);">+ secondary ctx, simply free it. If it's the primary</span><br><span style="color: hsl(120, 100%, 40%);">+ ctx, mark it as nodata but don't free it since we</span><br><span style="color: hsl(120, 100%, 40%);">+ need it to hold data linked together and we'll</span><br><span style="color: hsl(120, 100%, 40%);">+ require it later to tear down the entire tree. Still,</span><br><span style="color: hsl(120, 100%, 40%);">+ we announce its deletion through cb_delete_context</span><br><span style="color: hsl(120, 100%, 40%);">+ because we don't want user to release its related</span><br><span style="color: hsl(120, 100%, 40%);">+ data and not use it anymore.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span> if (gsn->cb_delete_context)</span><br><span> gsn->cb_delete_context(pdp);</span><br><span> if (pdp == linked_pdp) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14286">change 14286</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14286"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia47ac792111fe1e9aa68222b32b5da823642206b </div>
<div style="display:none"> Gerrit-Change-Number: 14286 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-MessageType: merged </div>