<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/14261">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  osmith: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/msc_vty.c: do not abuse strlen() to check char buffers<br><br>In the most cases we need to check whether particular char buffer<br>is empty or not. Using strlen() for that involves more CPU power,<br>so let's just check the first character against '\0'.<br><br>Change-Id: I8728876b80c870e82247e6e56f719e10ed322a95<br>---<br>M src/libmsc/msc_vty.c<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c</span><br><span>index 5b0cfc4..8a976cb 100644</span><br><span>--- a/src/libmsc/msc_vty.c</span><br><span>+++ b/src/libmsc/msc_vty.c</span><br><span>@@ -793,11 +793,11 @@</span><br><span> {</span><br><span>    char buf[128];</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if (strlen(vsub->name)) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (vsub->name[0] != '\0') {</span><br><span>              MSC_VTY_DUMP(vty, offset, "Name: '%s'%s",</span><br><span>                       vsub->name, VTY_NEWLINE);</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       if (strlen(vsub->msisdn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+        if (vsub->msisdn[0] != '\0') {</span><br><span>            MSC_VTY_DUMP(vty, offset, "MSISDN: %s%s",</span><br><span>                       vsub->msisdn, VTY_NEWLINE);</span><br><span>  }</span><br><span>@@ -873,8 +873,7 @@</span><br><span>                   osmo_fsm_inst_state_name(vsub->sgs_fsm),</span><br><span>                  VTY_NEWLINE);</span><br><span>   MSC_VTY_DUMP(vty, offset, "SGs-MME: %s%s",</span><br><span style="color: hsl(0, 100%, 40%);">-                 strlen(vsub->sgs.mme_name) ?</span><br><span style="color: hsl(0, 100%, 40%);">-                         vsub->sgs.mme_name : "(none)",</span><br><span style="color: hsl(120, 100%, 40%);">+                   vsub->sgs.mme_name[0] != '\0' ? vsub->sgs.mme_name : "(none)",</span><br><span>               VTY_NEWLINE);</span><br><span> </span><br><span>       MSC_VTY_DUMP(vty, offset, "Use count total: %d%s",</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/14261">change 14261</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/14261"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8728876b80c870e82247e6e56f719e10ed322a95 </div>
<div style="display:none"> Gerrit-Change-Number: 14261 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>