<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14325">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/scheduler: fix: do not ignore SACCH prims with odd length<br><br>Before this patch, prim_dequeue_sacch() used to ignore SACCH primitives<br>with odd length (e.g. 21, when sender forgot to push 2 octets of L1<br>SACCH header), so neither they were transmitted, nor rejected.<br><br>As a result, they would stay in the Tx queue until a dedicated<br>connection is released. The only way to notice such problem<br>was looking at the constantly growing talloc's report.<br><br>Instead of ignoring the primitives with odd length and keeping them<br>in the queue, let's pass them to a logical channel handler, so they<br>would be dequeued and rejected with a proper logging event.<br><br>Also, to simplify further debugging, let's print the final decision<br>of SACCH prioritization: whether it's a Measurement Report or not.<br><br>Change-Id: I3149fa518439470b397953306209eb859c83450a<br>---<br>M src/host/trxcon/sched_prim.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/25/14325/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c</span><br><span>index 275a050..50dfd6e 100644</span><br><span>--- a/src/host/trxcon/sched_prim.c</span><br><span>+++ b/src/host/trxcon/sched_prim.c</span><br><span>@@ -253,10 +253,6 @@</span><br><span>                 if (prim->chan != lchan->type)</span><br><span>                         continue;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* Just to be sure... */</span><br><span style="color: hsl(0, 100%, 40%);">-                if (prim->payload_len != GSM_MACBLOCK_LEN)</span><br><span style="color: hsl(0, 100%, 40%);">-                   continue;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>            /* Look for a Measurement Report */</span><br><span>          if (!prim_mr && PRIM_IS_MR(prim))</span><br><span>                    prim_mr = prim;</span><br><span>@@ -307,6 +303,10 @@</span><br><span>       /* Update the MR transmission state */</span><br><span>       lchan->sacch.mr_tx_last = PRIM_IS_MR(prim);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+    LOGP(DSCHD, LOGL_DEBUG, "SACCH decision on lchan=%s: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+         trx_lchan_desc[lchan->type].name, PRIM_IS_MR(prim) ?</span><br><span style="color: hsl(120, 100%, 40%);">+                       "Measurement Report" : "data frame");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  return prim;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14325">change 14325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3149fa518439470b397953306209eb859c83450a </div>
<div style="display:none"> Gerrit-Change-Number: 14325 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>