<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14317">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lapdm: Don't truncate L3 payload at 200 bytes length<br><br>3GPP TS 04.06 is quite clear that the [segmented] L3 payload can be as<br>long as 251 bytes.  Our libosmocore lapdm implementation truncated<br>already at 200 bytes :(<br><br>Change-Id: I6769986f27dda1d429ed7b2e32c36d34663acba9<br>Closes: OS#4035<br>---<br>M src/gsm/lapdm.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/14317/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c</span><br><span>index d76175b..f1651d6 100644</span><br><span>--- a/src/gsm/lapdm.c</span><br><span>+++ b/src/gsm/lapdm.c</span><br><span>@@ -136,7 +136,7 @@</span><br><span> {</span><br><span>    memset(dl, 0, sizeof(*dl));</span><br><span>  dl->entity = entity;</span><br><span style="color: hsl(0, 100%, 40%);">- lapd_dl_init(&dl->dl, 1, 8, 200);</span><br><span style="color: hsl(120, 100%, 40%);">+      lapd_dl_init(&dl->dl, 1, 8, 251); /* Section 5.8.5 of TS 04.06 */</span><br><span>     dl->dl.reestablish = 0; /* GSM uses no reestablish */</span><br><span>     dl->dl.send_ph_data_req = lapdm_send_ph_data_req;</span><br><span>         dl->dl.send_dlsap = send_rslms_dlsap;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14317">change 14317</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14317"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6769986f27dda1d429ed7b2e32c36d34663acba9 </div>
<div style="display:none"> Gerrit-Change-Number: 14317 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>