<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14272">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">trxcon/l1ctl.c: on L1CTL_DM_EST_REQ, determine pchan_config first<br><br>It makes sense to do this first, before tuning to a different<br>ARFCN and changing the training sequence. Otherwise, if no<br>multi-frame configuration is found, trxcon would switch to<br>a different channel and then remain inactive there.<br><br>Change-Id: I274588ce3a9c49372b5da0629930afece46f799c<br>---<br>M src/host/trxcon/l1ctl.c<br>1 file changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/72/14272/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c</span><br><span>index d745295..fff1c2b 100644</span><br><span>--- a/src/host/trxcon/l1ctl.c</span><br><span>+++ b/src/host/trxcon/l1ctl.c</span><br><span>@@ -637,6 +637,14 @@</span><br><span>             "(tn=%u, chan_nr=0x%02x, tsc=%u, tch_mode=0x%02x)\n",</span><br><span>              tn, chan_nr, est_req->tsc, est_req->tch_mode);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      /* Determine channel config */</span><br><span style="color: hsl(120, 100%, 40%);">+        config = sched_trx_chan_nr2pchan_config(chan_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (config == GSM_PCHAN_NONE) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGP(DL1C, LOGL_ERROR, "Couldn't determine channel config\n");</span><br><span style="color: hsl(120, 100%, 40%);">+          rc = -EINVAL;</span><br><span style="color: hsl(120, 100%, 40%);">+         goto exit;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* Frequency hopping? */</span><br><span>     if (est_req->h)</span><br><span>           rc = l1ctl_proc_est_req_h1(l1l->trx, &est_req->h1);</span><br><span>@@ -648,14 +656,6 @@</span><br><span>         /* Update TSC (Training Sequence Code) */</span><br><span>    l1l->trx->tsc = est_req->tsc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      /* Determine channel config */</span><br><span style="color: hsl(0, 100%, 40%);">-  config = sched_trx_chan_nr2pchan_config(chan_nr);</span><br><span style="color: hsl(0, 100%, 40%);">-       if (config == GSM_PCHAN_NONE) {</span><br><span style="color: hsl(0, 100%, 40%);">-         LOGP(DL1C, LOGL_ERROR, "Couldn't determine channel config\n");</span><br><span style="color: hsl(0, 100%, 40%);">-            rc = -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-           goto exit;</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    /* Configure requested TS */</span><br><span>         rc = sched_trx_configure_ts(l1l->trx, tn, config);</span><br><span>        ts = l1l->trx->ts_list[tn];</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14272">change 14272</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14272"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I274588ce3a9c49372b5da0629930afece46f799c </div>
<div style="display:none"> Gerrit-Change-Number: 14272 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>