<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14241">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Document max retransmit times for T3395<br><br>Spec also states same value is used for T3390, which we don't yet<br>implement.<br><br>Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/41/14241/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index a18a54e..e7f0bfe 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -67,6 +67,9 @@</span><br><span> </span><br><span> #define PTMSI_ALLOC</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 04.08 sec 6.1.3.4.3(.a) "Abnormal cases" */</span><br><span style="color: hsl(120, 100%, 40%);">+#define T339X_MAX_RETRANS 4</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> extern struct sgsn_instance *sgsn;</span><br><span> extern void *tall_sgsn_ctx;</span><br><span> </span><br><span>@@ -2797,8 +2800,8 @@</span><br><span> </span><br><span>  switch (pdp->T) {</span><br><span>         case 3395:      /* waiting for PDP CTX DEACT ACK */</span><br><span style="color: hsl(0, 100%, 40%);">-             if (pdp->num_T_exp >= 5) {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired >= 5 times\n");</span><br><span style="color: hsl(120, 100%, 40%);">+              if (pdp->num_T_exp > T339X_MAX_RETRANS) {</span><br><span style="color: hsl(120, 100%, 40%);">+                       LOGPDPCTXP(LOGL_NOTICE, pdp, "T3395 expired > %d times\n", T339X_MAX_RETRANS);</span><br><span>                  pdp->state = PDP_STATE_INACTIVE;</span><br><span>                  if (pdp->ggsn)</span><br><span>                            sgsn_delete_pdp_ctx(pdp);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14241">change 14241</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14241"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I1a2276bd42d1ea5706cf9cc26d3e44baa6fbf066 </div>
<div style="display:none"> Gerrit-Change-Number: 14241 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>