<p><a href="https://gerrit.osmocom.org/14195">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14195/1//COMMIT_MSG@22">Patch Set #1, Line 22:</a> <code style="font-family:monospace,monospace">  auth-policy c</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">So you say in this case argv[0] is "c" instead of "closed"? That's IMHO wrong and should be fixed in […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, the VTY parser would pass any of those variations.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I guess the problem is that we are doing:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  strncmp( choice, input, strlen(input) )</pre><p style="white-space: pre-wrap; word-wrap: break-word;">somewhere in the VTY code, so for example:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  strncmp( "accept-all", "accept", 6 ) == 0<br>  strncmp( "accept-all", "acc", 3 ) == 0<br>  strncmp( "accept-all", "a", 1 ) == 0<br>  strncmp( "accept-all", "", 0 ) == 0</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Also, that's probably why you can type:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">  - "en" instead of "enable",<br>  - "subscr" instead of "subscriber".</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Unfortunately, I am not familiar with the internals of libosmovty, so for now it makes sense at least to avoid segfault'ing here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/14195">change 14195</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14195"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If9b0c0d031477ca87786aab5c269d00748e896c8 </div>
<div style="display:none"> Gerrit-Change-Number: 14195 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 27 May 2019 08:54:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>