<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14215">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Verify SI3 GPRS indication reflects PCU interface status<br><br>When no PCU is connected to the BTS, the BTS should mask the GPRS<br>indicator from the SI3 rest octets to indicate "no GPRS support"<br>in the cell. This will cause phones not even trying to send us<br>RACH requests for GPRS ATTACH, RAU, etc.<br><br>Change-Id: I37efb712ee0c513aea230beeb35e7dabce698a34<br>Related: OS#4023<br>Related: OS#3075<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 172 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/14215/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 6786d68..c5e3f7e 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -245,7 +245,7 @@</span><br><span> },</span><br><span> cell_sel_par := ts_CellSelPar_default,</span><br><span> rach_control := ts_RachCtrl_default,</span><br><span style="color: hsl(0, 100%, 40%);">- rest_octets := '2B2B2B2B'O</span><br><span style="color: hsl(120, 100%, 40%);">+ rest_octets := '2C2B2B2B'O /* GPRS present */</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span>@@ -3941,6 +3941,174 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Ensure that GPRS capability is not advertised before PCU socket conncet */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_get_si3(L1CTL_PT pt) runs on test_CT return SystemInformationType3 {</span><br><span style="color: hsl(120, 100%, 40%);">+ var L1ctlDlMessage l1_dl;</span><br><span style="color: hsl(120, 100%, 40%);">+ var SystemInformation si;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 5.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] pt.receive(tr_L1CTL_DATA_IND(t_RslChanNr_BCCH(0), ?)) -> value l1_dl {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* somehow dec_SystemInformation will try to decode even non-RR as SI */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not (l1_dl.payload.data_ind.payload[1] == '06'O)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Ignoring non-RR SI ", l1_dl);</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ si := dec_SystemInformation(l1_dl.payload.data_ind.payload)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not ischosen(si.payload.si3)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] pt.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Timeout waiting for SI3");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return si.payload.si3;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* CSN.1 L/H logic: is the bit at the current position using "inverted logic" (true) or not? */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_bitpos_is_inv(integer idx) return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ select (idx mod 8) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case ((2, 4, 6, 7)) { return true; } /* 1-bits of 0x2B */</span><br><span style="color: hsl(120, 100%, 40%);">+ case else { return false; } /* 0-bits of 0x2B */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+/* determine if the bit at position 'idx' in 'str' is a CSN.1 'H' (true) or 'L' (false) */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_bit_is_high(bitstring str, integer idx) return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean invert := f_bitpos_is_inv(idx);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (invert) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (str[idx] == '1'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+ return false;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ return true;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (str[idx] == '1'B) {</span><br><span style="color: hsl(120, 100%, 40%);">+ return true;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ return false;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+/* As the TITAN RAW codec cannot expres the CSN.1 L/H concept yet, we have to do this</span><br><span style="color: hsl(120, 100%, 40%);">+ manually. Let's hope https://www.eclipse.org/forums/index.php/t/1099087/ takes off and</span><br><span style="color: hsl(120, 100%, 40%);">+ we can replace this piece of code soon ... */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_si3_has_gprs_indicator(OCT4 si3_restoctets) return boolean {</span><br><span style="color: hsl(120, 100%, 40%);">+ var bitstring bits := oct2bit(si3_restoctets);</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer idx := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_bit_is_high(bits, idx)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* skip Optional selection parameters */</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 16;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_bit_is_high(bits, idx)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* skip Optional power offset */</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* skip SI2ter Indicator */</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* skip Early CM Sending Control */</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* skip Scheduling if and where */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_bit_is_high(bits, idx)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 4;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ idx := idx + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return f_bit_is_high(bits, idx);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_pcu_socket_noconnect_nosi3gprs() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SystemInformationType3 si3;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 5.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* don't call f_init() as this would connect PCU socket */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_rsl(testcasename());</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] RSL_CCHAN.receive(ASP_IPA_Event:{up_down := ASP_IPA_EVENT_UP});</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Timeout waiting for ASP_IPA_EVENT_UP");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rsl_bcch_fill(RSL_SYSTEM_INFO_3, ts_SI3_default);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_l1ctl();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(2.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ si3 := f_get_si3(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_si3_has_gprs_indicator(si3.rest_octets)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "SI3 indicates GPRS even before PCU socket connected");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Ensure that GPRS capability is advertised after PCU socket connect */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_pcu_socket_connect_si3gprs() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SystemInformationType3 si3;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* this (among other things) establishes the first connection to the PCUIF socket */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_l1ctl();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(2.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ si3 := f_get_si3(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not f_si3_has_gprs_indicator(si3.rest_octets)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "SI3 indicates no GPRS despite PCU socket connected");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Ensure that GPRS capability is no longer advertised after PCU socket disconnect */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_pcu_socket_disconnect_nosi3gprs() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var SystemInformationType3 si3;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* this (among other things) establishes the first connection to the PCUIF socket */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_l1ctl();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_l1_tune(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pcuif_close(PCU, g_pcu_conn_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ g_pcu_conn_id := -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* re-connect */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCU.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_pcu(PCU, testcasename(), g_pcu_conn_id, g_pcu_last_info);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(2.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ L1CTL.clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ si3 := f_get_si3(L1CTL);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (f_si3_has_gprs_indicator(si3.rest_octets)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "SI3 indicates GPRS after PCU socket disconnected");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> </span><br><span> /***********************************************************************</span><br><span> * Osmocom Style Dynamic Timeslot Support</span><br><span>@@ -5251,6 +5419,9 @@</span><br><span> execute( TC_pcu_rr_suspend() );</span><br><span> execute( TC_pcu_socket_connect_multi() );</span><br><span> execute( TC_pcu_socket_reconnect() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_pcu_socket_noconnect_nosi3gprs() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_pcu_socket_connect_si3gprs() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_pcu_socket_disconnect_nosi3gprs() );</span><br><span> } else {</span><br><span> log("PCU socket path not available, skipping PCU tests");</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14215">change 14215</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14215"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I37efb712ee0c513aea230beeb35e7dabce698a34 </div>
<div style="display:none"> Gerrit-Change-Number: 14215 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>