<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14170">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, but someone else must approve
  Vadim Yanitskiy: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp_pcu: make gprs_bssgp_ns_cb public<br><br>rename the function sgsn_ns_cb -> gprs_bssgp_ns_cb.<br>To allow writing and reading the same configuration, the pcu needs to register<br>all vty commands before reading the configuration. This callback<br>is required to register NS based vty commands<br><br>Related: OS#4024<br>Change-Id: I440c0df2e32fe22bf43288c00bb4aa3a0c6a3a51<br>---<br>M src/gprs_bssgp_pcu.cpp<br>M src/gprs_bssgp_pcu.h<br>2 files changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp</span><br><span>index 9d02df6..50f10db 100644</span><br><span>--- a/src/gprs_bssgp_pcu.cpp</span><br><span>+++ b/src/gprs_bssgp_pcu.cpp</span><br><span>@@ -520,7 +520,7 @@</span><br><span>       return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static int sgsn_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc, struct msgb *msg, uint16_t bvci)</span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_bssgp_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc, struct msgb *msg, uint16_t bvci)</span><br><span> {</span><br><span>         int rc = 0;</span><br><span>  switch (event) {</span><br><span>@@ -913,7 +913,7 @@</span><br><span> </span><br><span>   the_pcu.bts = bts;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  bssgp_nsi = gprs_ns_instantiate(&sgsn_ns_cb, tall_pcu_ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+       bssgp_nsi = gprs_ns_instantiate(&gprs_bssgp_ns_cb, tall_pcu_ctx);</span><br><span>        if (!bssgp_nsi) {</span><br><span>            LOGP(DBSSGP, LOGL_ERROR, "Failed to create NS instance\n");</span><br><span>                return NULL;</span><br><span>diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h</span><br><span>index e8ae1a9..f98e719 100644</span><br><span>--- a/src/gprs_bssgp_pcu.h</span><br><span>+++ b/src/gprs_bssgp_pcu.h</span><br><span>@@ -80,6 +80,9 @@</span><br><span>                uint16_t nsvci, uint16_t bvci, uint16_t mcc, uint16_t mnc, bool mnc_3_digits,</span><br><span>                uint16_t lac, uint16_t rac, uint16_t cell_id);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_bssgp_ns_cb(enum gprs_ns_evt event, struct gprs_nsvc *nsvc,</span><br><span style="color: hsl(120, 100%, 40%);">+             struct msgb *msg, uint16_t bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> void gprs_bssgp_destroy(void);</span><br><span> </span><br><span> struct bssgp_bvc_ctx *gprs_bssgp_pcu_current_bctx(void);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14170">change 14170</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14170"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I440c0df2e32fe22bf43288c00bb4aa3a0c6a3a51 </div>
<div style="display:none"> Gerrit-Change-Number: 14170 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>