<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14189">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm48_encode_bcd_number(): zero-initialize optional header between L and V<br><br>Change-Id: Iafd911dd55691b3715391e3899cd6971245c8d7f<br>---<br>M src/gsm/gsm48_ie.c<br>M tests/gsm0408/gsm0408_test.ok<br>M tests/sms/sms_test.ok<br>3 files changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/14189/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/gsm48_ie.c b/src/gsm/gsm48_ie.c</span><br><span>index 688698d..77cd472 100644</span><br><span>--- a/src/gsm/gsm48_ie.c</span><br><span>+++ b/src/gsm/gsm48_ie.c</span><br><span>@@ -161,6 +161,10 @@</span><br><span> if (i % 2)</span><br><span> *bcd_cur++ |= 0xf0;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* zero-initialize optional header between L and V */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < h_len; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ bcd_lv[i + 1] = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* return how many bytes we used */</span><br><span> return (bcd_cur - bcd_lv);</span><br><span> }</span><br><span>diff --git a/tests/gsm0408/gsm0408_test.ok b/tests/gsm0408/gsm0408_test.ok</span><br><span>index 075886e..8a65399 100644</span><br><span>--- a/tests/gsm0408/gsm0408_test.ok</span><br><span>+++ b/tests/gsm0408/gsm0408_test.ok</span><br><span>@@ -150,7 +150,7 @@</span><br><span> - Running test: regular 6-digit MSISDN with optional header (LHV)</span><br><span> - Encoding ASCII (buffer limit=0) '123456'...</span><br><span> - Expected: (rc=8) '0700000000214365'</span><br><span style="color: hsl(0, 100%, 40%);">- - Actual: (rc=8) '0721436587214365'</span><br><span style="color: hsl(120, 100%, 40%);">+ - Actual: (rc=8) '0700000000214365'</span><br><span> - Decoding HEX (buffer limit=0) '07deadbeef214365'...</span><br><span> - Expected: (rc=0) '123456'</span><br><span> - Actual: (rc=0) '123456'</span><br><span>diff --git a/tests/sms/sms_test.ok b/tests/sms/sms_test.ok</span><br><span>index a71567d..0a45c01 100644</span><br><span>--- a/tests/sms/sms_test.ok</span><br><span>+++ b/tests/sms/sms_test.ok</span><br><span>@@ -13,9 +13,9 @@</span><br><span> SEPTETS: 8 OCTETS: 7</span><br><span> Done</span><br><span> Testing gsm340_gen_oa</span><br><span style="color: hsl(0, 100%, 40%);">-Result: len(12) data(14 81 21 43 65 87 09 21 43 65 87 19 )</span><br><span style="color: hsl(0, 100%, 40%);">-Result: len(12) data(14 a1 21 43 65 87 09 21 43 65 87 19 )</span><br><span style="color: hsl(0, 100%, 40%);">-Result: len(2) data(00 91 )</span><br><span style="color: hsl(120, 100%, 40%);">+Result: len(12) data(14 00 21 43 65 87 09 21 43 65 87 19 )</span><br><span style="color: hsl(120, 100%, 40%);">+Result: len(12) data(14 00 21 43 65 87 09 21 43 65 87 19 )</span><br><span style="color: hsl(120, 100%, 40%);">+Result: len(2) data(00 00 )</span><br><span> Result: len(9) data(0e d0 4f 78 d9 2d 9c 0e 01 )</span><br><span> Result: len(12) data(14 d0 4f 78 d9 2d 9c 0e c3 e2 31 19 )</span><br><span> OK</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14189">change 14189</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14189"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iafd911dd55691b3715391e3899cd6971245c8d7f </div>
<div style="display:none"> Gerrit-Change-Number: 14189 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>