<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14175">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rx_fail_evt_rep(): Don't recycle variable<br><br>the 'p_val' variable should represent he 'probabl cause value' and<br>nothing else.  Let's use other local variables for other things.<br><br>Change-Id: Ie79279fc1d42cd57e7478820493b250fe38c2f4f<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/14175/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 240517b..bff6c12 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -368,8 +368,8 @@</span><br><span>                        oh->length-sizeof(*foh));</span><br><span> </span><br><span>   if (TLVP_PRESENT(&tp, NM_ATT_ADD_TEXT)) {</span><br><span style="color: hsl(0, 100%, 40%);">-           p_val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT);</span><br><span style="color: hsl(0, 100%, 40%);">-             p_text = talloc_strndup(tall_bsc_ctx, (const char *) p_val,</span><br><span style="color: hsl(120, 100%, 40%);">+           const uint8_t *val = TLVP_VAL(&tp, NM_ATT_ADD_TEXT);</span><br><span style="color: hsl(120, 100%, 40%);">+              p_text = talloc_strndup(tall_bsc_ctx, (const char *) val,</span><br><span>                                    TLVP_LEN(&tp, NM_ATT_ADD_TEXT));</span><br><span>         }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14175">change 14175</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14175"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ie79279fc1d42cd57e7478820493b250fe38c2f4f </div>
<div style="display:none"> Gerrit-Change-Number: 14175 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>