<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14166">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lms: Fix stream_stats checks with droppedPackets<br><br>Existing code had a typo (value was assigned from wrong variable).<br>Furthermore, it was experimentally found that:<br>while underrun/overrun are documented as "FIFO overrun<br>count" in LimeSuite.h, it seems droppedPackets ("Number of dropped<br>packets by HW") is not actually an incrementing counter like the others,<br>but simply a value set every time LMS_RecvStream() is called. Since we<br>are actually interested in keeping the count over time, adjust code to<br>achieve that.<br><br>Change-Id: Id93d33400e11360b9536f56a31904328549cfbbf<br>---<br>M Transceiver52M/device/lms/LMSDevice.cpp<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/66/14166/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>index c320540..a1ca983 100644</span><br><span>--- a/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>+++ b/Transceiver52M/device/lms/LMSDevice.cpp</span><br><span>@@ -597,12 +597,14 @@</span><br><span>             }</span><br><span>            m_last_rx_overruns[chan] = status.overrun;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-          if (status.droppedPackets > m_last_rx_dropped[chan]) {</span><br><span style="color: hsl(120, 100%, 40%);">+             if (status.droppedPackets) {</span><br><span>                         LOGCHAN(chan, DDEV, ERROR) << "recv Dropped packets by HW! ("</span><br><span>                                                   << m_last_rx_dropped[chan] << " -> "</span><br><span style="color: hsl(0, 100%, 40%);">-                                                   << status.droppedPackets << ")";</span><br><span style="color: hsl(120, 100%, 40%);">+                                                << m_last_rx_dropped[chan] +</span><br><span style="color: hsl(120, 100%, 40%);">+                                               status.droppedPackets</span><br><span style="color: hsl(120, 100%, 40%);">+                                              << ")";</span><br><span>           }</span><br><span style="color: hsl(0, 100%, 40%);">-               m_last_rx_dropped[chan] = m_last_rx_overruns[chan];</span><br><span style="color: hsl(120, 100%, 40%);">+           m_last_rx_dropped[chan] += status.droppedPackets;</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14166">change 14166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14166"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Id93d33400e11360b9536f56a31904328549cfbbf </div>
<div style="display:none"> Gerrit-Change-Number: 14166 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>