<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14108">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts: Test case for mixed NORMAL and DEFAULT SMSCB<br><br>This adds TC_sms_cb_cmd_sdcch{4,8]_default_and_normal() which test<br>the correct behavior in case of a DEFAULT SMSCB and normal one-shot<br>SMSCBs.<br><br>Change-Id: I0782b121cd69158903b09f935b298ddbf5a9ffb5<br>Related: OS#4011<br>---<br>M bts/BTS_Tests_SMSCB.ttcn<br>1 file changed, 19 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests_SMSCB.ttcn b/bts/BTS_Tests_SMSCB.ttcn</span><br><span>index e1efd63..874acb4 100644</span><br><span>--- a/bts/BTS_Tests_SMSCB.ttcn</span><br><span>+++ b/bts/BTS_Tests_SMSCB.ttcn</span><br><span>@@ -608,6 +608,23 @@</span><br><span>      Misc_Helpers.f_shutdown(__BFILE__, __LINE__, pass);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_sms_cb_cmd_sdcch4_default_and_normal() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+    var CbchTestPars pars := {</span><br><span style="color: hsl(120, 100%, 40%);">+            use_sdcch4 := true,</span><br><span style="color: hsl(120, 100%, 40%);">+           basic := valueof(t_CbchPC(msgs_1m_3b_norm, msg_default)),</span><br><span style="color: hsl(120, 100%, 40%);">+             extended := omit</span><br><span style="color: hsl(120, 100%, 40%);">+      };</span><br><span style="color: hsl(120, 100%, 40%);">+    f_TC_smscb(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_sms_cb_cmd_sdcch8_default_and_normal() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+    var CbchTestPars pars := {</span><br><span style="color: hsl(120, 100%, 40%);">+            use_sdcch4 := true,</span><br><span style="color: hsl(120, 100%, 40%);">+           basic := valueof(t_CbchPC(msgs_1m_3b_norm, msg_default)),</span><br><span style="color: hsl(120, 100%, 40%);">+             extended := omit</span><br><span style="color: hsl(120, 100%, 40%);">+      };</span><br><span style="color: hsl(120, 100%, 40%);">+    f_TC_smscb(pars);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* first set a DEFAULT message, then disable it again */</span><br><span> testcase TC_sms_cb_cmd_sdcch4_default_then_null() runs on test_CT {</span><br><span>    var CbchTestPars pars := {</span><br><span>@@ -668,6 +685,7 @@</span><br><span>     execute( TC_sms_cb_cmd_sdcch4_multi() );</span><br><span>     execute( TC_sms_cb_cmd_sdcch4_schedule() );</span><br><span>  execute( TC_sms_cb_cmd_sdcch4_default_only() );</span><br><span style="color: hsl(120, 100%, 40%);">+       execute( TC_sms_cb_cmd_sdcch4_default_and_normal() );</span><br><span>        execute( TC_sms_cb_cmd_sdcch4_default_then_null() );</span><br><span>         if (false) { /* FIXME: SDCCH/8 support broken, needs trxcon + L1CTL work */</span><br><span>  execute( TC_sms_cb_cmd_sdcch8_1block() );</span><br><span>@@ -677,6 +695,7 @@</span><br><span>      execute( TC_sms_cb_cmd_sdcch8_multi() );</span><br><span>     execute( TC_sms_cb_cmd_sdcch8_schedule() );</span><br><span>  execute( TC_sms_cb_cmd_sdcch8_default_only() );</span><br><span style="color: hsl(120, 100%, 40%);">+       execute( TC_sms_cb_cmd_sdcch8_default_and_normal() );</span><br><span>        }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14108">change 14108</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14108"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0782b121cd69158903b09f935b298ddbf5a9ffb5 </div>
<div style="display:none"> Gerrit-Change-Number: 14108 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>