<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14125">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_rsl: Add support for extended CBCH to rsl_sms_cb_command()<br><br>Now that OsmoBTS understands about extended CBCH, let's at least<br>update the BSC side function to allow for other code to generate<br>such messages.<br><br>Change-Id: I77a16b75ce311d63fb022475c8ff25fbbcee7f55<br>---<br>M include/osmocom/bsc/abis_rsl.h<br>M src/osmo-bsc/abis_rsl.c<br>M src/osmo-bsc/bsc_vty.c<br>3 files changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/25/14125/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h</span><br><span>index 098d2e6..ec63090 100644</span><br><span>--- a/include/osmocom/bsc/abis_rsl.h</span><br><span>+++ b/include/osmocom/bsc/abis_rsl.h</span><br><span>@@ -90,7 +90,7 @@</span><br><span> /* SMSCB functionality */</span><br><span> int rsl_sms_cb_command(struct gsm_bts *bts, uint8_t chan_number,</span><br><span>                        struct rsl_ie_cb_cmd_type cb_command,</span><br><span style="color: hsl(0, 100%, 40%);">-                   const uint8_t *data, int len);</span><br><span style="color: hsl(120, 100%, 40%);">+                bool use_extended_cbch, const uint8_t *data, int len);</span><br><span> </span><br><span> /* some Nokia specific stuff */</span><br><span> int rsl_nokia_si_begin(struct gsm_bts_trx *trx);</span><br><span>diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c</span><br><span>index bc07457..5a1c8ff 100644</span><br><span>--- a/src/osmo-bsc/abis_rsl.c</span><br><span>+++ b/src/osmo-bsc/abis_rsl.c</span><br><span>@@ -2172,7 +2172,7 @@</span><br><span> </span><br><span> int rsl_sms_cb_command(struct gsm_bts *bts, uint8_t chan_number,</span><br><span>                   struct rsl_ie_cb_cmd_type cb_command,</span><br><span style="color: hsl(0, 100%, 40%);">-                   const uint8_t *data, int len)</span><br><span style="color: hsl(120, 100%, 40%);">+                 bool use_extended_cbch, const uint8_t *data, int len)</span><br><span> {</span><br><span>    struct abis_rsl_dchan_hdr *dh;</span><br><span>       struct msgb *cb_cmd;</span><br><span>@@ -2188,6 +2188,8 @@</span><br><span> </span><br><span>     msgb_tv_put(cb_cmd, RSL_IE_CB_CMD_TYPE, *(uint8_t*)&cb_command);</span><br><span>         msgb_tlv_put(cb_cmd, RSL_IE_SMSCB_MSG, len, data);</span><br><span style="color: hsl(120, 100%, 40%);">+    if (use_extended_cbch)</span><br><span style="color: hsl(120, 100%, 40%);">+                msgb_tv_put(cb_cmd, RSL_IE_SMSCB_CHAN_INDICATOR, 0x01);</span><br><span> </span><br><span>  cb_cmd->dst = bts->c0->rsl_link;</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c</span><br><span>index dc97d12..88c845b 100644</span><br><span>--- a/src/osmo-bsc/bsc_vty.c</span><br><span>+++ b/src/osmo-bsc/bsc_vty.c</span><br><span>@@ -4582,7 +4582,7 @@</span><br><span>           return CMD_WARNING;</span><br><span>  }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   rsl_sms_cb_command(bts, RSL_CHAN_SDCCH4_ACCH, cb_cmd, buf, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+       rsl_sms_cb_command(bts, RSL_CHAN_SDCCH4_ACCH, cb_cmd, false, buf, rc);</span><br><span> </span><br><span>   return CMD_SUCCESS;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14125">change 14125</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14125"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I77a16b75ce311d63fb022475c8ff25fbbcee7f55 </div>
<div style="display:none"> Gerrit-Change-Number: 14125 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>