<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14082">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lapdm_rslms_recvmsg: Fix memory leak in error path<br><br>The caller of lapdm_rslms_recvmsg() (e.g. osmo-bts/src/common/rsl.c)<br>assumes the message ownership is transferred.  However, in one of the<br>two error paths, msgb_free() was not called and hence we had a memory<br>leak.<br><br>Also clarify the msgb ownership transfer in a comment.<br><br>Related: OS#3750<br>Change-Id: Id60cb45e50bfc89224d97df6c68fcd2949751895<br>---<br>M src/gsm/lapdm.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c</span><br><span>index ba9b3df..d76175b 100644</span><br><span>--- a/src/gsm/lapdm.c</span><br><span>+++ b/src/gsm/lapdm.c</span><br><span>@@ -1269,7 +1269,8 @@</span><br><span>        return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/*! Receive a RSLms \ref msgb from Layer 3 */</span><br><span style="color: hsl(120, 100%, 40%);">+/*! Receive a RSLms \ref msgb from Layer 3. 'msg' ownership is transferred,</span><br><span style="color: hsl(120, 100%, 40%);">+ *  i.e. caller must not free it */</span><br><span> int lapdm_rslms_recvmsg(struct msgb *msg, struct lapdm_channel *lc)</span><br><span> {</span><br><span>       struct abis_rsl_common_hdr *rslh = msgb_l2(msg);</span><br><span>@@ -1277,6 +1278,7 @@</span><br><span> </span><br><span>         if (msgb_l2len(msg) < sizeof(*rslh)) {</span><br><span>            LOGP(DLLAPD, LOGL_ERROR, "Message too short RSL hdr!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+           msgb_free(msg);</span><br><span>              return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14082">change 14082</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14082"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Id60cb45e50bfc89224d97df6c68fcd2949751895 </div>
<div style="display:none"> Gerrit-Change-Number: 14082 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>