<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13713">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Create subscribers on demand<br><br>Add a new vty option and allow to optionally generate a random msisdn,<br>as well as setting the default NAM:<br><br>subscriber-create-on-demand (no-msisdn|<3-15>) (none|cs|ps|both)<br><br>Thanks to Vadim for the random MSISDN patch [1], which was squashed into<br>this one.<br><br>[1] Change-Id: I475c71f9902950fa7498855a616e1ec231fad6ac<br><br>Depends on: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1 (libosmocore)<br>Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd<br>Related: OS#2542<br>---<br>M src/hlr.c<br>M src/hlr.h<br>M src/hlr_vty.c<br>M tests/test_nodes.vty<br>A tests/test_subscr_create_on_demand.vty<br>5 files changed, 186 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index 0bea590..694ba14 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -34,6 +34,8 @@</span><br><span> #include <osmocom/ctrl/control_vty.h></span><br><span> #include <osmocom/gsm/apn.h></span><br><span> #include <osmocom/gsm/gsm48_ie.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/gsm_utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/protocol/gsm_23_003.h></span><br><span> </span><br><span> #include "db.h"</span><br><span> #include "hlr.h"</span><br><span>@@ -148,6 +150,78 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static int generate_new_msisdn(char *msisdn, const char *imsi, unsigned int len)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int i, j, rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t rand_buf[GSM23003_MSISDN_MAX_DIGITS];</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(len <= sizeof(rand_buf));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Generate a random unique MSISDN (with retry) */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < 10; i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Get a random number (with retry) */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < 10; j++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = osmo_get_rand_id(rand_buf, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rc)</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "IMSI='%s': Failed to generate new MSISDN, random number generator"</span><br><span style="color: hsl(120, 100%, 40%);">+ " failed (rc=%d)\n", imsi, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Shift 0x00 ... 0xff range to 30 ... 39 (ASCII numbers) */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (j = 0; j < len; j++)</span><br><span style="color: hsl(120, 100%, 40%);">+ msisdn[j] = 48 + (rand_buf[j] % 10);</span><br><span style="color: hsl(120, 100%, 40%);">+ msisdn[j] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Ensure there is no subscriber with such MSISDN */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (db_subscr_exists_by_msisdn(g_hlr->dbc, msisdn) == -ENOENT)</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Failure */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "IMSI='%s': Failed to generate a new MSISDN, consider increasing "</span><br><span style="color: hsl(120, 100%, 40%);">+ "the length for the automatically assigned MSISDNs "</span><br><span style="color: hsl(120, 100%, 40%);">+ "(see 'subscriber-create-on-demand' command)\n", imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static int subscr_create_on_demand(const char *imsi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ char msisdn[GSM23003_MSISDN_MAX_DIGITS + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int rand_msisdn_len = g_hlr->subscr_create_on_demand_rand_msisdn_len;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!g_hlr->subscr_create_on_demand)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (db_subscr_exists_by_imsi(g_hlr->dbc, imsi) == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rand_msisdn_len && generate_new_msisdn(msisdn, imsi, rand_msisdn_len) != 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_INFO, "IMSI='%s': Creating subscriber on demand\n", imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = db_subscr_create(g_hlr->dbc, imsi, g_hlr->subscr_create_on_demand_flags);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "Failed to create subscriber on demand (rc=%d): IMSI='%s'\n", rc, imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!rand_msisdn_len)</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Update MSISDN of the new (just allocated) subscriber */</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = db_subscr_update_msisdn_by_imsi(g_hlr->dbc, imsi, msisdn);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_ERROR, "IMSI='%s': Failed to assign MSISDN='%s' (rc=%d)\n", imsi, msisdn, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMAIN, LOGL_INFO, "IMSI='%s': Successfully assigned MSISDN='%s'\n", imsi, msisdn);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span> * Send Auth Info handling</span><br><span> ***********************************************************************/</span><br><span>@@ -161,6 +235,8 @@</span><br><span> struct msgb *msg_out;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr_create_on_demand(gsup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* initialize return message structure */</span><br><span> memset(&gsup_out, 0, sizeof(gsup_out));</span><br><span> memcpy(&gsup_out.imsi, &gsup->imsi, sizeof(gsup_out.imsi));</span><br><span>@@ -291,6 +367,8 @@</span><br><span> }</span><br><span> llist_add(&luop->list, &g_lu_ops);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr_create_on_demand(gsup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Roughly follwing "Process Update_Location_HLR" of TS 09.02 */</span><br><span> </span><br><span> /* check if subscriber is known at all */</span><br><span>@@ -415,6 +493,8 @@</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ subscr_create_on_demand(gsup->imsi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Save in DB if desired */</span><br><span> if (g_hlr->store_imei) {</span><br><span> LOGP(DAUC, LOGL_DEBUG, "IMSI='%s': storing IMEI = %s\n", gsup->imsi, imei);</span><br><span>diff --git a/src/hlr.h b/src/hlr.h</span><br><span>index e2e96a4..18c4a1d 100644</span><br><span>--- a/src/hlr.h</span><br><span>+++ b/src/hlr.h</span><br><span>@@ -56,6 +56,11 @@</span><br><span> struct llist_head ss_sessions;</span><br><span> </span><br><span> bool store_imei;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bool subscr_create_on_demand;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Bitmask of DB_SUBSCR_FLAG_* */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t subscr_create_on_demand_flags;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int subscr_create_on_demand_rand_msisdn_len;</span><br><span> };</span><br><span> </span><br><span> extern struct hlr *g_hlr;</span><br><span>diff --git a/src/hlr_vty.c b/src/hlr_vty.c</span><br><span>index e4cc4be..e6567cc 100644</span><br><span>--- a/src/hlr_vty.c</span><br><span>+++ b/src/hlr_vty.c</span><br><span>@@ -33,6 +33,7 @@</span><br><span> #include <osmocom/vty/misc.h></span><br><span> #include <osmocom/abis/ipa.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include "db.h"</span><br><span> #include "hlr.h"</span><br><span> #include "hlr_vty.h"</span><br><span> #include "hlr_vty_subscr.h"</span><br><span>@@ -76,6 +77,23 @@</span><br><span> vty_out(vty, " store-imei%s", VTY_NEWLINE);</span><br><span> if (g_hlr->db_file_path && strcmp(g_hlr->db_file_path, HLR_DEFAULT_DB_FILE_PATH))</span><br><span> vty_out(vty, " database %s%s", g_hlr->db_file_path, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (g_hlr->subscr_create_on_demand) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *flags_str = "none";</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t flags = g_hlr->subscr_create_on_demand_flags;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int rand_msisdn_len = g_hlr->subscr_create_on_demand_rand_msisdn_len;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if ((flags & DB_SUBSCR_FLAG_NAM_CS) && (flags & DB_SUBSCR_FLAG_NAM_PS))</span><br><span style="color: hsl(120, 100%, 40%);">+ flags_str = "cs+ps";</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (flags & DB_SUBSCR_FLAG_NAM_CS)</span><br><span style="color: hsl(120, 100%, 40%);">+ flags_str = "cs";</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (flags & DB_SUBSCR_FLAG_NAM_PS)</span><br><span style="color: hsl(120, 100%, 40%);">+ flags_str = "ps";</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rand_msisdn_len)</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " subscriber-create-on-demand %i %s%s", rand_msisdn_len, flags_str, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span style="color: hsl(120, 100%, 40%);">+ vty_out(vty, " subscriber-create-on-demand no-msisdn %s%s", flags_str, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span>@@ -336,6 +354,42 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_subscr_create_on_demand, cfg_subscr_create_on_demand_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "subscriber-create-on-demand (no-msisdn|<3-15>) (none|cs|ps|cs+ps)",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Make a new record when a subscriber is first seen.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Do not automatically assign MSISDN.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Length of an automatically assigned MSISDN.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Do not allow any NAM (Network Access Mode) by default.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Allow access to circuit switched NAM by default.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Allow access to packet switched NAM by default.\n"</span><br><span style="color: hsl(120, 100%, 40%);">+ "Allow access to circuit and packet switched NAM by default.\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int rand_msisdn_len = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t flags = 0x00;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strcmp(argv[0], "no-msisdn") != 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ rand_msisdn_len = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strstr(argv[1], "cs"))</span><br><span style="color: hsl(120, 100%, 40%);">+ flags |= DB_SUBSCR_FLAG_NAM_CS;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (strstr(argv[1], "ps"))</span><br><span style="color: hsl(120, 100%, 40%);">+ flags |= DB_SUBSCR_FLAG_NAM_PS;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->subscr_create_on_demand = true;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->subscr_create_on_demand_rand_msisdn_len = rand_msisdn_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->subscr_create_on_demand_flags = flags;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_no_subscr_create_on_demand, cfg_no_subscr_create_on_demand_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+ "no subscriber-create-on-demand",</span><br><span style="color: hsl(120, 100%, 40%);">+ "Do not make a new record when a subscriber is first seen.\n")</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ g_hlr->subscr_create_on_demand = false;</span><br><span style="color: hsl(120, 100%, 40%);">+ return CMD_SUCCESS;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /***********************************************************************</span><br><span> * Common Code</span><br><span> ***********************************************************************/</span><br><span>@@ -404,6 +458,8 @@</span><br><span> install_element(HLR_NODE, &cfg_ncss_guard_timeout_cmd);</span><br><span> install_element(HLR_NODE, &cfg_store_imei_cmd);</span><br><span> install_element(HLR_NODE, &cfg_no_store_imei_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(HLR_NODE, &cfg_subscr_create_on_demand_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(HLR_NODE, &cfg_no_subscr_create_on_demand_cmd);</span><br><span> </span><br><span> hlr_vty_subscriber_init();</span><br><span> }</span><br><span>diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty</span><br><span>index a4e53db..bf2afaf 100644</span><br><span>--- a/tests/test_nodes.vty</span><br><span>+++ b/tests/test_nodes.vty</span><br><span>@@ -86,6 +86,8 @@</span><br><span> ncss-guard-timeout <0-255></span><br><span> store-imei</span><br><span> no store-imei</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand (no-msisdn|<3-15>) (none|cs|ps|cs+ps)</span><br><span style="color: hsl(120, 100%, 40%);">+ no subscriber-create-on-demand</span><br><span> </span><br><span> OsmoHLR(config-hlr)# gsup</span><br><span> OsmoHLR(config-hlr-gsup)# list</span><br><span>diff --git a/tests/test_subscr_create_on_demand.vty b/tests/test_subscr_create_on_demand.vty</span><br><span>new file mode 100644</span><br><span>index 0000000..fb587ae</span><br><span>--- /dev/null</span><br><span>+++ b/tests/test_subscr_create_on_demand.vty</span><br><span>@@ -0,0 +1,43 @@</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR> enable</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR# configure terminal</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config)# hlr</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# subscriber-create-on-demand no-msisdn none</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+hlr</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand no-msisdn none</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# subscriber-create-on-demand 3 none</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+hlr</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand 3 none</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# subscriber-create-on-demand 4 cs</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+hlr</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand 4 cs</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# subscriber-create-on-demand 5 ps</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+hlr</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand 5 ps</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# subscriber-create-on-demand 6 cs+ps</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoHLR(config-hlr)# show running-config</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+hlr</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ subscriber-create-on-demand 6 cs+ps</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13713">change 13713</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13713"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I0c9fe93f5c24b5e9fefb513c4d049fb7ebd47ecd </div>
<div style="display:none"> Gerrit-Change-Number: 13713 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Assignee: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>