<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14081">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-ggsn: properly show subscriber's MSISDN in the VTY<br><br>Instead of printing subscriber's MSISDN as a hex-string, let's<br>attempt to decode it using gsm48_decode_bcd_number2().<br><br>Change-Id: I3f3a105dc8d0d582f2b9d8e1ff6c5785369e569b<br>---<br>M ggsn/ggsn_vty.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn_vty.c b/ggsn/ggsn_vty.c</span><br><span>index 214e2fa..c6dc0d9 100644</span><br><span>--- a/ggsn/ggsn_vty.c</span><br><span>+++ b/ggsn/ggsn_vty.c</span><br><span>@@ -27,6 +27,7 @@</span><br><span> #include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/rate_ctr.h></span><br><span> #include <osmocom/gsm/apn.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/gsm48_ie.h></span><br><span> #include <osmocom/gsm/protocol/gsm_04_08_gprs.h></span><br><span> </span><br><span> #include <osmocom/vty/command.h></span><br><span>@@ -736,9 +737,14 @@</span><br><span>       struct in46_addr eua46;</span><br><span>      char name_buf[256];</span><br><span>  char *apn_name;</span><br><span style="color: hsl(120, 100%, 40%);">+       int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* Attempt to decode MSISDN */</span><br><span style="color: hsl(120, 100%, 40%);">+        rc = gsm48_decode_bcd_number2(name_buf, sizeof(name_buf),</span><br><span style="color: hsl(120, 100%, 40%);">+                                   pdp->msisdn.v, pdp->msisdn.l, 0);</span><br><span> </span><br><span>    vty_out(vty, "IMSI: %s, NSAPI: %u, MSISDN: %s%s", imsi_gtp2str(&pdp->imsi), pdp->nsapi,</span><br><span style="color: hsl(0, 100%, 40%);">-             osmo_hexdump_nospc(pdp->msisdn.v, pdp->msisdn.l), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         rc ? "(NONE)" : name_buf, VTY_NEWLINE);</span><br><span> </span><br><span>        vty_out(vty, " Control: %s:%08x ", print_gsnaddr(&pdp->gsnlc), pdp->teic_own);</span><br><span>   vty_out(vty, "<-> %s:%08x%s", print_gsnaddr(&pdp->gsnrc), pdp->teic_gn, VTY_NEWLINE);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14081">change 14081</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14081"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3f3a105dc8d0d582f2b9d8e1ff6c5785369e569b </div>
<div style="display:none"> Gerrit-Change-Number: 14081 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>