<p>Harald Welte has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14087">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">RSL: Fix off-by-one error when parsing SACCH INFO IE in RSL CHAN ACT<br><br>This off-by-one error in length verification caused all SACCH INFO IE<br>to be deemed invalid and hence any RSL CHAN ACT with that IE to be<br>rejected.<br><br>Change-Id: I6436caf5c2caefbf7c089d66e37d8d1babe1c24e<br>Related: OS#3750<br>---<br>M src/common/rsl.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/14087/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/rsl.c b/src/common/rsl.c</span><br><span>index 829a4e6..99e38b0 100644</span><br><span>--- a/src/common/rsl.c</span><br><span>+++ b/src/common/rsl.c</span><br><span>@@ -1133,7 +1133,7 @@</span><br><span>                       lapdm_ui_prefix_lchan(lchan, cur, osmo_si, si_len);</span><br><span> </span><br><span>                      cur += si_len;</span><br><span style="color: hsl(0, 100%, 40%);">-                  if (cur >= val + tot_len) {</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (cur > val + tot_len) {</span><br><span>                                LOGP(DRSL, LOGL_ERROR, "Error parsing SACCH INFO IE\n");</span><br><span>                           rsl_tx_error_report(msg->trx, RSL_ERR_IE_CONTENT, &dch->chan_nr,</span><br><span>                                               NULL, msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14087">change 14087</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14087"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I6436caf5c2caefbf7c089d66e37d8d1babe1c24e </div>
<div style="display:none"> Gerrit-Change-Number: 14087 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>