<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14034">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmux: Improve logging around osmux enabling events<br><br>Change-Id: Iab687b97010fd484cb353b240b120c9c382066fa<br>---<br>M src/libosmo-mgcp/mgcp_osmux.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>index 9bbc1b2..4423194 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>@@ -325,12 +325,14 @@</span><br><span>         case OSMUX_STATE_ACTIVATING:</span><br><span>         if (osmux_enable_conn(endp, conn, &conn->end.addr, conn->end.rtp_port) < 0) {</span><br><span>                   LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                              "Could not enable osmux for conn:%s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                             "Could not enable osmux for conn on %s: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                              sending ? "sent" : "received",</span><br><span>                           mgcp_conn_dump(conn->conn));</span><br><span>                     return -1;</span><br><span>           }</span><br><span>            LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                      "Osmux CID %u for %s:%u is now enabled\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                  "Osmux %s CID %u towards %s:%u is now enabled\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   sending ? "sent" : "received",</span><br><span>                   conn->osmux.cid, inet_ntoa(conn->end.addr),</span><br><span>                    ntohs(conn->end.rtp_port));</span><br><span>              return 0;</span><br><span>@@ -697,8 +699,8 @@</span><br><span>              return 0;</span><br><span> </span><br><span>        LOGPCONN(conn->conn, DLMGCP, LOGL_DEBUG,</span><br><span style="color: hsl(0, 100%, 40%);">-              "sending OSMUX dummy load to %s CID %u\n",</span><br><span style="color: hsl(0, 100%, 40%);">-            inet_ntoa(conn->end.addr), conn->osmux.cid);</span><br><span style="color: hsl(120, 100%, 40%);">+            "sending OSMUX dummy load to %s:%u CID %u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+               inet_ntoa(conn->end.addr), ntohs(conn->end.rtp_port), conn->osmux.cid);</span><br><span> </span><br><span>        return mgcp_udp_send(osmux_fd.fd, &conn->end.addr,</span><br><span>                         conn->end.rtp_port, buf, sizeof(buf));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14034">change 14034</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14034"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Iab687b97010fd484cb353b240b120c9c382066fa </div>
<div style="display:none"> Gerrit-Change-Number: 14034 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>