<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14066">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccid: Integrate libosmocore logging<br><br>Change-Id: I3436827f658653273af21f1deaf030c2a389f91a<br>---<br>M ccid/Makefile<br>M ccid/ccid_device.c<br>M ccid/ccid_device.h<br>M ccid/ccid_main_functionfs.c<br>4 files changed, 97 insertions(+), 22 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid/Makefile b/ccid/Makefile</span><br><span>index 317fcbd..cd8321f 100644</span><br><span>--- a/ccid/Makefile</span><br><span>+++ b/ccid/Makefile</span><br><span>@@ -1,7 +1,7 @@</span><br><span> CFLAGS=-Wall -g</span><br><span> </span><br><span> ccid_functionfs: ccid_main_functionfs.o ccid_proto.o ccid_device.o</span><br><span style="color: hsl(0, 100%, 40%);">- $(CC) $(CFLAGS) -lasan -losmocore -laio -o $@ $^</span><br><span style="color: hsl(120, 100%, 40%);">+ $(CC) $(CFLAGS) -lasan -losmocore -ltalloc -laio -o $@ $^</span><br><span> </span><br><span> %.o: %.c</span><br><span> $(CC) $(CFLAGS) -o $@ -c $^</span><br><span>diff --git a/ccid/ccid_device.c b/ccid/ccid_device.c</span><br><span>index e3705ae..ffcbacc 100644</span><br><span>--- a/ccid/ccid_device.c</span><br><span>+++ b/ccid/ccid_device.c</span><br><span>@@ -6,6 +6,7 @@</span><br><span> </span><br><span> #include <osmocom/core/msgb.h></span><br><span> #include <osmocom/core/utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span> </span><br><span> #include "ccid_proto.h"</span><br><span> #include "ccid_device.h"</span><br><span>@@ -157,6 +158,15 @@</span><br><span> /* Send given CCID message */</span><br><span> static int ccid_send(struct ccid_instance *ci, struct msgb *msg)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ccid_header *ch = (struct ccid_header *) msgb_ccid_in(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ccid_slot *cs = get_ccid_slot(ci, ch->bSlot);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (cs) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPCS(cs, LOGL_DEBUG, "Tx CCID(IN) %s %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ get_value_string(ccid_msg_type_vals, ch->bMessageType), msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPCI(ci, LOGL_DEBUG, "Tx CCID(IN) %s %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ get_value_string(ccid_msg_type_vals, ch->bMessageType), msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> return ci->ops->send_in(ci, msg);</span><br><span> }</span><br><span> </span><br><span>@@ -470,24 +480,32 @@</span><br><span> switch (spar->bProtocolNum) {</span><br><span> case CCID_PROTOCOL_NUM_T0:</span><br><span> rc = decode_ccid_pars_t0(&pars_dec, &spar->abProtocolData.t0);</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_ERROR, "SetParameters: Unable to parse T0: %d\n", rc);</span><br><span> resp = ccid_gen_parameters_t0(cs, seq, CCID_CMD_STATUS_FAILED, -rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> /* FIXME: validate parameters; abort if they are not supported */</span><br><span> cs->pars = pars_dec;</span><br><span> resp = ccid_gen_parameters_t0(cs, seq, CCID_CMD_STATUS_OK, 0);</span><br><span> break;</span><br><span> case CCID_PROTOCOL_NUM_T1:</span><br><span> rc = decode_ccid_pars_t1(&pars_dec, &spar->abProtocolData.t1);</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_ERROR, "SetParameters: Unable to parse T1: %d\n", rc);</span><br><span> resp = ccid_gen_parameters_t1(cs, seq, CCID_CMD_STATUS_FAILED, -rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> /* FIXME: validate parameters; abort if they are not supported */</span><br><span> cs->pars = pars_dec;</span><br><span> resp = ccid_gen_parameters_t1(cs, seq, CCID_CMD_STATUS_OK, 0);</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_ERROR, "SetParameters: Invalid Protocol 0x%02x\n",spar->bProtocolNum);</span><br><span> resp = ccid_gen_parameters_t0(cs, seq, CCID_CMD_STATUS_FAILED, 0);</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+out:</span><br><span> return ccid_slot_send_unbusy(cs, resp);</span><br><span> }</span><br><span> </span><br><span>@@ -573,6 +591,7 @@</span><br><span> //case PC_to_RDR_Abort: /* seriously? WTF! */</span><br><span> break;</span><br><span> default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_ERROR, "Abort for non-Abortable Message Type\n");</span><br><span> /* CCID spec lists CMD_NOT_ABORTED, but gives no numberic value ?!? */</span><br><span> resp = ccid_gen_slot_status(cs, seq, CCID_CMD_STATUS_FAILED, CCID_ERR_CMD_NOT_SUPPORTED);</span><br><span> return ccid_slot_send_unbusy(cs, resp);</span><br><span>@@ -617,18 +636,23 @@</span><br><span> /* Check for invalid slot number */</span><br><span> cs = get_ccid_slot(ci, ch->bSlot);</span><br><span> if (!cs) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPCI(ci, LOGL_ERROR, "Invalid bSlot %u\n", ch->bSlot);</span><br><span> resp = gen_err_resp(ch->bMessageType, ch->bSlot, CCID_ICC_STATUS_NO_ICC, ch->bSeq, 5);</span><br><span> return ccid_send(ci, resp);</span><br><span> }</span><br><span> </span><br><span> /* Check if slot is already busy; Reject any additional commands meanwhile */</span><br><span> if (cs->cmd_busy) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPCS(cs, LOGL_ERROR, "Slot Busy, but another cmd received\n");</span><br><span> /* FIXME: ABORT logic as per section 5.3.1 of CCID Spec v1.1 */</span><br><span> resp = gen_err_resp(ch->bMessageType, ch->bSlot, get_icc_status(cs), ch->bSeq,</span><br><span> CCID_ERR_CMD_SLOT_BUSY);</span><br><span> return ccid_send(ci, resp);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPCS(cs, LOGL_DEBUG, "Rx CCID(OUT) %s %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ get_value_string(ccid_msg_type_vals, ch->bMessageType), msgb_hexdump(msg));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* we're now processing a command for the slot; mark slot as busy */</span><br><span> cs->cmd_busy = true;</span><br><span> </span><br><span>@@ -707,6 +731,7 @@</span><br><span> break;</span><br><span> default:</span><br><span> /* generic response with bERror = 0 (command not supported) */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_NOTICE, "Unknown CCID Message received: 0x%02x\n", ch->bMessageType);</span><br><span> resp = gen_err_resp(ch->bMessageType, ch->bSlot, CCID_ICC_STATUS_NO_ICC, ch->bSeq,</span><br><span> CCID_ERR_CMD_NOT_SUPPORTED);</span><br><span> return ccid_slot_send_unbusy(cs, resp);</span><br><span>@@ -714,7 +739,7 @@</span><br><span> return 0;</span><br><span> </span><br><span> short_msg:</span><br><span style="color: hsl(0, 100%, 40%);">- /* FIXME */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, LOGL_ERROR, "Short CCID message received: %s; ignoring\n", msgb_hexdump(msg));</span><br><span> return -1;</span><br><span> }</span><br><span> </span><br><span>diff --git a/ccid/ccid_device.h b/ccid/ccid_device.h</span><br><span>index 4cdb325..68ec98a 100644</span><br><span>--- a/ccid/ccid_device.h</span><br><span>+++ b/ccid/ccid_device.h</span><br><span>@@ -2,12 +2,16 @@</span><br><span> #include <stdbool.h></span><br><span> #include <stdint.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+enum {</span><br><span style="color: hsl(120, 100%, 40%);">+ DCCID,</span><br><span style="color: hsl(120, 100%, 40%);">+ DUSB,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span> </span><br><span> #define NR_SLOTS 8</span><br><span> </span><br><span> #define LOGPCI(ci, lvl, fmt, args ...) LOGP(DCCID, lvl, "%s: " fmt, (ci)->name, ## args)</span><br><span> #define LOGPCS(cs, lvl, fmt, args ...) \</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DCCID, lvl, "%s(%u): " fmt, (cc)->ci->name, (cc)->slot_nr, ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DCCID, lvl, "%s(%u): " fmt, (cs)->ci->name, (cs)->slot_nr, ## args)</span><br><span> </span><br><span> struct msgb;</span><br><span> </span><br><span>diff --git a/ccid/ccid_main_functionfs.c b/ccid/ccid_main_functionfs.c</span><br><span>index 2b57182..717a6ae 100644</span><br><span>--- a/ccid/ccid_main_functionfs.c</span><br><span>+++ b/ccid/ccid_main_functionfs.c</span><br><span>@@ -1,4 +1,5 @@</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <errno.h></span><br><span> #include <stdint.h></span><br><span> #include <endian.h></span><br><span> #include <sys/types.h></span><br><span>@@ -132,6 +133,9 @@</span><br><span> #include <osmocom/core/select.h></span><br><span> #include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/msgb.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/application.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span> </span><br><span> #include "ccid_device.h"</span><br><span> </span><br><span>@@ -161,7 +165,7 @@</span><br><span> </span><br><span> static int ep_int_cb(struct osmo_fd *ofd, unsigned int what)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("INT\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "%s\n", __func__);</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -171,7 +175,7 @@</span><br><span> struct msgb *msg = msgb_alloc(512, "OUT-Rx");</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("OUT\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "%s\n", __func__);</span><br><span> if (what & BSC_FD_READ) {</span><br><span> rc = read(ofd->fd, msgb_data(msg), msgb_tailroom(msg));</span><br><span> if (rc <= 0) {</span><br><span>@@ -187,7 +191,7 @@</span><br><span> </span><br><span> static int ep_in_cb(struct osmo_fd *ofd, unsigned int what)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("IN\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "%s\n", __func__);</span><br><span> if (what & BSC_FD_WRITE) {</span><br><span> /* write what we have to write */</span><br><span> }</span><br><span>@@ -207,11 +211,10 @@</span><br><span> </span><br><span> static void handle_setup(const struct usb_ctrlrequest *setup)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- printf("bRequestType = %d\n", setup->bRequestType);</span><br><span style="color: hsl(0, 100%, 40%);">- printf("bRequest = %d\n", setup->bRequest);</span><br><span style="color: hsl(0, 100%, 40%);">- printf("wValue = %d\n", le16_to_cpu(setup->wValue));</span><br><span style="color: hsl(0, 100%, 40%);">- printf("wIndex = %d\n", le16_to_cpu(setup->wIndex));</span><br><span style="color: hsl(0, 100%, 40%);">- printf("wLength = %d\n", le16_to_cpu(setup->wLength));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_NOTICE, "EP0 SETUP bRequestType=0x%02x, bRequest=0x%02x wValue=0x%04x, "</span><br><span style="color: hsl(120, 100%, 40%);">+ "wIndex=0x%04x, wLength=%u\n", setup->bRequestType, setup->bRequest,</span><br><span style="color: hsl(120, 100%, 40%);">+ le16_to_cpu(setup->wValue), le16_to_cpu(setup->wIndex), le16_to_cpu(setup->wLength));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* FIXME: Handle control transfer */</span><br><span> }</span><br><span> </span><br><span> static void aio_refill_out(struct ufunc_handle *uh);</span><br><span>@@ -221,14 +224,12 @@</span><br><span> struct ufunc_handle *uh = (struct ufunc_handle *) ofd->data;</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- printf("EP0\n");</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> if (what & BSC_FD_READ) {</span><br><span> struct usb_functionfs_event evt;</span><br><span> rc = read(ofd->fd, (uint8_t *)&evt, sizeof(evt));</span><br><span> if (rc < sizeof(evt))</span><br><span> return -23;</span><br><span style="color: hsl(0, 100%, 40%);">- printf("\t%s\n", get_value_string(ffs_evt_type_names, evt.type));</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_NOTICE, "EP0 %s\n", get_value_string(ffs_evt_type_names, evt.type));</span><br><span> switch (evt.type) {</span><br><span> case FUNCTIONFS_ENABLE:</span><br><span> aio_refill_out(uh);</span><br><span>@@ -248,6 +249,8 @@</span><br><span> {</span><br><span> int rc;</span><br><span> struct aio_help *ah = &uh->aio_out;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "%s\n", __func__);</span><br><span> msgb_reset(ah->msg);</span><br><span> io_prep_pread(ah->iocb, uh->ep_out.fd, msgb_data(ah->msg), msgb_tailroom(ah->msg), 0);</span><br><span> io_set_eventfd(ah->iocb, uh->aio_evfd.fd);</span><br><span>@@ -266,24 +269,31 @@</span><br><span> assert(rc == sizeof(ev_cnt));</span><br><span> </span><br><span> rc = io_getevents(uh->aio_ctx, 1, 3, evt, NULL);</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc <= 0)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc <= 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_ERROR, "error in io_getevents(): %d\n", rc);</span><br><span> return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> for (i = 0; i < rc; i++) {</span><br><span> int fd = evt[i].obj->aio_fildes;</span><br><span> if (fd == uh->ep_int.fd) {</span><br><span> /* interrupt endpoint AIO has completed. This means the IRQ transfer</span><br><span> * which we generated has reached the host */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "IRQ AIO completed, free()ing msgb\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(uh->aio_in.msg);</span><br><span style="color: hsl(120, 100%, 40%);">+ uh->aio_in.msg = NULL;</span><br><span> } else if (fd == uh->ep_in.fd) {</span><br><span> /* IN endpoint AIO has completed. This means the IN transfer which</span><br><span> * we sent to the host has completed */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "IN AIO completed, free()ing msgb\n");</span><br><span> msgb_free(uh->aio_in.msg);</span><br><span> uh->aio_in.msg = NULL;</span><br><span> } else if (fd == uh->ep_out.fd) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* IN endpoint AIO has completed. This means the host has sent us</span><br><span style="color: hsl(120, 100%, 40%);">+ /* OUT endpoint AIO has completed. This means the host has sent us</span><br><span> * some OUT data */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_DEBUG, "OUT AIO completed, dispatching received msg\n");</span><br><span> msgb_put(uh->aio_out.msg, evt[i].res);</span><br><span style="color: hsl(0, 100%, 40%);">- printf("\t%s\n", msgb_hexdump(uh->aio_out.msg));</span><br><span style="color: hsl(120, 100%, 40%);">+ //printf("\t%s\n", msgb_hexdump(uh->aio_out.msg));</span><br><span> //ccid_handle_out(uh->ccid_handle, uh->aio_out.buf, evt[i].res);</span><br><span> ccid_handle_out(uh->ccid_handle, uh->aio_out.msg);</span><br><span> aio_refill_out(uh);</span><br><span>@@ -304,11 +314,15 @@</span><br><span> osmo_fd_setup(&uh->ep0, rc, BSC_FD_READ, &ep_0_cb, uh, 0);</span><br><span> osmo_fd_register(&uh->ep0);</span><br><span> rc = write(uh->ep0.fd, &descriptors, sizeof(descriptors));</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc != sizeof(descriptors))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != sizeof(descriptors)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_ERROR, "Cannot write descriptors: %s\n", strerror(errno));</span><br><span> return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> rc = write(uh->ep0.fd, &strings, sizeof(strings));</span><br><span style="color: hsl(0, 100%, 40%);">- if (rc != sizeof(strings))</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc != sizeof(strings)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DUSB, LOGL_ERROR, "Cannot write strings: %s\n", strerror(errno));</span><br><span> return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span> /* open other endpoint file descriptors */</span><br><span> rc = open("ep1", O_RDWR);</span><br><span>@@ -378,20 +392,52 @@</span><br><span> .send_in = ccid_ops_send_in,</span><br><span> };</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static const struct log_info_cat log_info_cat[] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ [DUSB] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "USB",</span><br><span style="color: hsl(120, 100%, 40%);">+ .description = "USB Transport",</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ [DCCID] = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .name = "CCID",</span><br><span style="color: hsl(120, 100%, 40%);">+ .description = "CCID Core",</span><br><span style="color: hsl(120, 100%, 40%);">+ .color = "\033[1;35m",</span><br><span style="color: hsl(120, 100%, 40%);">+ .enabled = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .loglevel = LOGL_DEBUG,</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const struct log_info log_info = {</span><br><span style="color: hsl(120, 100%, 40%);">+ .cat = log_info_cat,</span><br><span style="color: hsl(120, 100%, 40%);">+ .num_cat = ARRAY_SIZE(log_info_cat),</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void *tall_main_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int main(int argc, char **argv)</span><br><span> {</span><br><span> struct ufunc_handle ufh = (struct ufunc_handle) { 0, };</span><br><span> struct ccid_instance ci = (struct ccid_instance) { 0, };</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ tall_main_ctx = talloc_named_const(NULL, 0, "ccid_main_functionfs");</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_talloc_ctx_init(tall_main_ctx, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_init_logging2(tall_main_ctx, &log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> ccid_instance_init(&ci, &c_ops, "", &ufh);</span><br><span> ufh.ccid_handle = &ci;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (argc < 2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "You have to specify the mount-path of the functionfs\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> chdir(argv[1]);</span><br><span> rc = ep0_init(&ufh);</span><br><span> if (rc < 0) {</span><br><span> fprintf(stderr, "Error %d\n", rc);</span><br><span style="color: hsl(0, 100%, 40%);">- exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(1);</span><br><span> }</span><br><span> </span><br><span> while (1) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14066">change 14066</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14066"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I3436827f658653273af21f1deaf030c2a389f91a </div>
<div style="display:none"> Gerrit-Change-Number: 14066 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>