<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13961">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Vadim Yanitskiy: Looks good to me, approved
tnt: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_23_003: add GSM23003_MSISDN_{MIN,MAX}_DIGITS<br><br>Add the constant, so it can be used in create-subscriber-on-demand<br>related patches. ITU-T Rec. E.164 6.1 states that maximum international<br>number length should be 15. I did not find a source for a minimum<br>length, but I've added the constant and set it to 1 for consistency<br>(based on the existing osmo_msisdn_str_valid() function).<br><br>Related: OS#2542<br>Change-Id: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1<br>---<br>M include/osmocom/gsm/protocol/gsm_23_003.h<br>M src/gsm/gsm23003.c<br>2 files changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_23_003.h b/include/osmocom/gsm/protocol/gsm_23_003.h</span><br><span>index be1b157..3e5c3e5 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_23_003.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_23_003.h</span><br><span>@@ -20,6 +20,9 @@</span><br><span> #define GSM23003_MME_CODE_NUM_BYTES 1</span><br><span> #define GSM23003_MME_GROUP_NUM_BYTES 2</span><br><span> #define GSM23003_MTMSI_NUM_BYTES 4</span><br><span style="color: hsl(120, 100%, 40%);">+/* Chapter 3.2 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define GSM23003_MSISDN_MAX_DIGITS 15 /* ITU-T Rec. E.164 6.1 */</span><br><span style="color: hsl(120, 100%, 40%);">+#define GSM23003_MSISDN_MIN_DIGITS 1</span><br><span> /* Chapter 6.2.1 */</span><br><span> #define GSM23003_IMEI_TAC_NUM_DIGITS 8</span><br><span> #define GSM23003_IMEI_SNR_NUM_DIGITS 6</span><br><span>diff --git a/src/gsm/gsm23003.c b/src/gsm/gsm23003.c</span><br><span>index 2252f70..a97ed07 100644</span><br><span>--- a/src/gsm/gsm23003.c</span><br><span>+++ b/src/gsm/gsm23003.c</span><br><span>@@ -69,7 +69,7 @@</span><br><span> */</span><br><span> bool osmo_msisdn_str_valid(const char *msisdn)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- return is_n_digits(msisdn, 1, 15);</span><br><span style="color: hsl(120, 100%, 40%);">+ return is_n_digits(msisdn, GSM23003_MSISDN_MIN_DIGITS, GSM23003_MSISDN_MAX_DIGITS);</span><br><span> }</span><br><span> </span><br><span> /*! Determine whether the given IMEI is valid according to 3GPP TS 23.003,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13961">change 13961</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13961"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: Idc74f4d94ad44b9fc1b6d43178f5f33d551ebfb1 </div>
<div style="display:none"> Gerrit-Change-Number: 13961 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>