<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13965">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vlr_lu_fsm.c: assert for invalid events<br><br>In state machine callback functions, instead of logging an error when<br>an invalid event arrives, do OSMO_ASSERT(0).<br><br>Change-Id: If5363ae37b414a0ac195e5f89664c75cbad0bb21<br>---<br>M src/libvlr/vlr_lu_fsm.c<br>1 file changed, 6 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c</span><br><span>index 27196d8..15ab88c 100644</span><br><span>--- a/src/libvlr/vlr_lu_fsm.c</span><br><span>+++ b/src/libvlr/vlr_lu_fsm.c</span><br><span>@@ -1086,8 +1086,7 @@</span><br><span>           _start_lu_main(fi);</span><br><span>          break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1104,8 +1103,7 @@</span><br><span>               vlr_loc_upd_want_imsi(fi);</span><br><span>           break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1170,8 +1168,7 @@</span><br><span>               vlr_loc_upd_node1(fi);</span><br><span>               break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1213,8 +1210,7 @@</span><br><span>               }</span><br><span>            break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1264,8 +1260,7 @@</span><br><span>               lu_fsm_failure(fi, cause);</span><br><span>           break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span>@@ -1297,8 +1292,7 @@</span><br><span>               lu_fsm_failure(fi, cause);</span><br><span>           break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGPFSML(fi, LOGL_ERROR, "event without effect: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                         osmo_fsm_event_name(fi->fsm, event));</span><br><span style="color: hsl(120, 100%, 40%);">+             OSMO_ASSERT(0);</span><br><span>              break;</span><br><span>       }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13965">change 13965</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13965"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: If5363ae37b414a0ac195e5f89664c75cbad0bb21 </div>
<div style="display:none"> Gerrit-Change-Number: 13965 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>