<p>Vadim Yanitskiy has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14045">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libmsc/ran_peer.c: avoid unreasonable use of goto in ran_peer_down_paging()<br><br>Change-Id: I3320240d8f1dc318e516162bb32e01ddafc7e30e<br>---<br>M src/libmsc/ran_peer.c<br>1 file changed, 2 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/14045/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/ran_peer.c b/src/libmsc/ran_peer.c</span><br><span>index a77cb89..40e26a2 100644</span><br><span>--- a/src/libmsc/ran_peer.c</span><br><span>+++ b/src/libmsc/ran_peer.c</span><br><span>@@ -640,15 +640,11 @@</span><br><span> {</span><br><span>       struct msgb *l2;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    if (cell_id_list_find(&rp->cells_seen, page_id, 0, false))</span><br><span style="color: hsl(0, 100%, 40%);">-               goto page_it;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        /* There are also the RAN peers that are configured in the neighbor ident for Handover, but if those aren't</span><br><span>       * connected, then we can't Page there. */</span><br><span style="color: hsl(120, 100%, 40%);">+        if (!cell_id_list_find(&rp->cells_seen, page_id, 0, false))</span><br><span style="color: hsl(120, 100%, 40%);">+            return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-page_it:</span><br><span>    LOG_RAN_PEER_CAT(rp, DPAG, LOGL_DEBUG, "Paging for %s on %s\n", vlr_subscr_name(vsub),</span><br><span>                      gsm0808_cell_id_name(page_id));</span><br><span>     l2 = rp->sri->ran->sccp_ran_ops.make_paging_msg(rp->sri, page_id, vsub->imsi, vsub->tmsi, cause);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14045">change 14045</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14045"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I3320240d8f1dc318e516162bb32e01ddafc7e30e </div>
<div style="display:none"> Gerrit-Change-Number: 14045 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>