<p>Harald Welte <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/13992">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  tnt: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">make LOG_TRANS() NULL-safe again<br><br>Previous patch [1] removed NULL-safety from LOG_TRANS(). Fix that.<br><br>In case a trans is NULL, it is fine to log in the DMSC category, since the<br>context should still be general (erratic message or other initial problems).<br><br>[1] 7f85acea9bb9f80e208820958f4cae63625f3689 / I6dfe5b98fb9e884c2dde61d603832dafceb12123<br>    "LOG_TRANS: store subsys in trans, unify USSD logging back to DMM"<br><br>Change-Id: I6e36c47bf828dd073b36c6301bbeabcc28e101e6<br>---<br>M include/osmocom/msc/transaction.h<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/msc/transaction.h b/include/osmocom/msc/transaction.h</span><br><span>index c63ef5b..9278b64 100644</span><br><span>--- a/include/osmocom/msc/transaction.h</span><br><span>+++ b/include/osmocom/msc/transaction.h</span><br><span>@@ -27,7 +27,7 @@</span><br><span>           ##args)</span><br><span> </span><br><span> #define LOG_TRANS(trans, level, fmt, args...) \</span><br><span style="color: hsl(0, 100%, 40%);">-          LOG_TRANS_CAT(trans, (trans)->log_subsys, level, fmt, ##args)</span><br><span style="color: hsl(120, 100%, 40%);">+      LOG_TRANS_CAT(trans, (trans) ? (trans)->log_subsys : DMSC, level, fmt, ##args)</span><br><span> </span><br><span> enum bridge_state {</span><br><span>    BRIDGE_STATE_NONE,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/13992">change 13992</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/13992"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I6e36c47bf828dd073b36c6301bbeabcc28e101e6 </div>
<div style="display:none"> Gerrit-Change-Number: 13992 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Neels Hofmeyr <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>