<p>Pau Espin Pedrol has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/14033">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmux: Use remote port to send osmux frames<br><br>Previously the local one was used but nobody cared because probably<br>everybody was using default 1984 on different IP addresses.<br><br>Change-Id: I01e590465fa247185d74103578681e9041249099<br>---<br>M src/libosmo-mgcp/mgcp_osmux.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/33/14033/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>index 7290ba3..9bbc1b2 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>@@ -323,7 +323,7 @@</span><br><span> {</span><br><span>    switch(conn->osmux.state) {</span><br><span>       case OSMUX_STATE_ACTIVATING:</span><br><span style="color: hsl(0, 100%, 40%);">-    if (osmux_enable_conn(endp, conn, &conn->end.addr, htons(endp->cfg->osmux_port)) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+       if (osmux_enable_conn(endp, conn, &conn->end.addr, conn->end.rtp_port) < 0) {</span><br><span>                   LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,</span><br><span>                           "Could not enable osmux for conn:%s\n",</span><br><span>                            mgcp_conn_dump(conn->conn));</span><br><span>@@ -332,7 +332,7 @@</span><br><span>               LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR,</span><br><span>                   "Osmux CID %u for %s:%u is now enabled\n",</span><br><span>                         conn->osmux.cid, inet_ntoa(conn->end.addr),</span><br><span style="color: hsl(0, 100%, 40%);">-                       endp->cfg->osmux_port);</span><br><span style="color: hsl(120, 100%, 40%);">+                         ntohs(conn->end.rtp_port));</span><br><span>              return 0;</span><br><span>    case OSMUX_STATE_ENABLED:</span><br><span>            return 0;</span><br><span>@@ -701,7 +701,7 @@</span><br><span>               inet_ntoa(conn->end.addr), conn->osmux.cid);</span><br><span> </span><br><span>      return mgcp_udp_send(osmux_fd.fd, &conn->end.addr,</span><br><span style="color: hsl(0, 100%, 40%);">-                            htons(endp->cfg->osmux_port), buf, sizeof(buf));</span><br><span style="color: hsl(120, 100%, 40%);">+                        conn->end.rtp_port, buf, sizeof(buf));</span><br><span> }</span><br><span> </span><br><span> /* bsc-nat allocates/releases the Osmux circuit ID. +7 to round up to 8 bit boundary. */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14033">change 14033</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14033"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I01e590465fa247185d74103578681e9041249099 </div>
<div style="display:none"> Gerrit-Change-Number: 14033 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>