<p>Pau Espin Pedrol <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/14013">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmux: Fix reception of legacy dummy payloads<br><br>Size check had a bug. Take the opportunity to print wrong frames on<br>error.<br><br>Change-Id: I9f0d4e28a2019c7ad94344f2c34d17c365bebea9<br>---<br>M src/libosmo-mgcp/mgcp_osmux.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>index ce89df1..9c3844f 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_osmux.c</span><br><span>@@ -348,9 +348,9 @@</span><br><span> static int osmux_legacy_dummy_parse_cid(struct sockaddr_in *addr, struct msgb *msg,</span><br><span>                                   uint8_t *osmux_cid)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        if (msg->len < 1 + sizeof(osmux_cid)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (msg->len < 1 + sizeof(*osmux_cid)) {</span><br><span>               LOGP(DLMGCP, LOGL_ERROR,</span><br><span style="color: hsl(0, 100%, 40%);">-                     "Discarding truncated Osmux dummy load\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 "Discarding truncated Osmux dummy load: %s\n", osmo_hexdump(msg->data, msg->len));</span><br><span>              return -1;</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/14013">change 14013</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/14013"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9f0d4e28a2019c7ad94344f2c34d17c365bebea9 </div>
<div style="display:none"> Gerrit-Change-Number: 14013 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Pau Espin Pedrol <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Harald Welte <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder (1000002) </div>
<div style="display:none"> Gerrit-Reviewer: Pau Espin Pedrol <pespin@sysmocom.de> </div>